Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python 3.13 compatibility #199

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update Python 3.13 compatibility #199

merged 1 commit into from
Nov 18, 2024
+4 −2

Conversation

DeD1rk
Copy link
Contributor

@DeD1rk DeD1rk commented Oct 19, 2024 •
edited
Loading

Fixes #186

Updates CI to build cp313 wheels. Adds pypy-3.10 testing as well.

See also #174.

@chayim could you take a look?

@DeD1rk
Update Python 3.13 compatibility
4ef2320 
Fixes redis#186

Updates CI to build cp313 wheels.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/redis/hiredis-py/issues/186?shareId=XXXX-XXXX-XXXX-XXXX).
@DeD1rk DeD1rk marked this pull request as ready for review October 19, 2024 08:59
@DeD1rk
Copy link
Contributor Author

DeD1rk commented Oct 19, 2024 •
edited
Loading

Update: I now see https://github.com/redis/hiredis-py/pull/198/files, so my comment below doesn't really apply.

As a sidenote, CHANGELOG.md doesn't match the release notes any more. So perhaps it's time to drop it, or update it up to a certain version and indicate that from then on, the github release notes server as changelog. If you agree I'm happy to make those changes of course.

@ArneTR ArneTR mentioned this pull request Oct 22, 2024
Merged
@junoriosity
Copy link

@DeD1rk @badboy @pietern @jparise @banker Is there some progress on that issue, as it would be terrific to allow it for Python 3.13. 🙂

@badboy
Copy link
Contributor

badboy commented Nov 3, 2024

I don't maintain this project anymore.

@Zaczero
Copy link

Zaczero commented Nov 4, 2024 •
edited
Loading

I think maintainers moved to valkey or something 😬

@douglasmiranda douglasmiranda mentioned this pull request Nov 17, 2024
Closed
@chayim
Copy link
Contributor

chayim commented Nov 17, 2024

@vladvildanov you

@vladvildanov
Copy link
Collaborator

Thanks @chayim for pinging me!

Guys just tag me on the PR's if you need a review

@vladvildanov vladvildanov merged commit 4113c71 into redis:master Nov 18, 2024
29 checks passed
@hxyannay
Copy link

hxyannay commented Dec 2, 2024

Hey @vladvildanov could you cut a new release for hi-redis so there would be python 3.13 wheels in pypi?

@vladvildanov
Copy link
Collaborator

@hxyannay Hey! Planned later this week

@vladvildanov
Copy link
Collaborator

@hxyannay Already available

@hxyannay
Copy link

hxyannay commented Dec 4, 2024

Hey @vladvildanov
I see that you released v3.1.0, but I do not see it under pypi here: https://pypi.org/simple/hiredis/
Also I see that the latest github action run failed on publishing to pypi, so maybe that's the cause.

@vladvildanov
Copy link
Collaborator

@hxyannay FIxed

@hxyannay
Copy link

hxyannay commented Dec 5, 2024

Thank you @vladvildanov 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladvildanov vladvildanov vladvildanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hiredis cannot be installed on Python 3.13
7 participants
@DeD1rk @junoriosity @badboy @Zaczero @chayim @vladvildanov @hxyannay