Return Redis sets as Python lists #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some (rare) cases, the sets from a Redis response contain nested types that are not hashable in Python, for example maps. To handle these cases uniformly, always return Python lists for Redis sets. The elements will still be unique, relying on the correctness of data arriving from the server.
vladvildanov
approved these changes
Jul 19, 2024
nijel
added a commit
to WeblateOrg/weblate
that referenced
this pull request
Jul 19, 2024
This might be discarded in some cases (see redis/hiredis-py#189).
nijel
added a commit
to WeblateOrg/weblate
that referenced
this pull request
Jul 19, 2024
This might be discarded in some cases (see redis/hiredis-py#189).
nijel
added a commit
to WeblateOrg/weblate
that referenced
this pull request
Jul 19, 2024
This might be discarded in some cases (see redis/hiredis-py#189).
renovate bot
pushed a commit
to WeblateOrg/weblate
that referenced
this pull request
Jul 19, 2024
This might be discarded in some cases (see redis/hiredis-py#189).
|
For others wondering whether this also requires changes in The merge commit for redis/redis-py#3324 (redis/redis-py@fd0b0d3) has been released in redis-py 5.1.0. Older versions should likely use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some (rare) cases, the sets from a Redis response contain nested types that are not hashable in Python, for example maps. To handle these cases uniformly, always return Python lists for Redis sets. The elements will still be unique, relying on the correctness of data arriving from the server.