Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken windows builds on python < 3.8 #151

Merged
merged 23 commits into from
Feb 2, 2023
Merged

Fixing broken windows builds on python < 3.8 #151

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
8e122b8
Implemented pack_bytes and pack_command.
prokazov-redis Jan 12, 2023
be55776
Bump version + make it work in a clean environment
prokazov-redis Jan 14, 2023
2d45fb1
pack_command that passes redis-py test (*almost*)
prokazov-redis Jan 16, 2023
fdb1314
Removed pack-bytes and added some tests.
prokazov-redis Jan 18, 2023
96e5d8e
Removed pack-bytes and added some tests.
prokazov-redis Jan 18, 2023
143a81c
Merge branch 'pack_command'
prokazov-redis Jan 18, 2023
ff5ccaa
even more clean up.
prokazov-redis Jan 18, 2023
83edbe8
Re-factored tests and added a couple more ones.
prokazov Jan 19, 2023
b54372d
1) Fix the compiler warning in pack.c
prokazov Jan 19, 2023
a5f8a3b
1) Fixed typo.
prokazov-redis Jan 23, 2023
241000c
1) Fixed typo.
prokazov-redis Jan 23, 2023
4a416d7
Autopep-8 on setup.py
prokazov-redis Jan 23, 2023
5807460
Drop extra link args
prokazov Jan 25, 2023
8643b7c
add conditional compile flags excluding windows and mac
zalmane Jan 25, 2023
3517354
Remove egg-info
prokazov Jan 25, 2023
05fe090
1) add conditional compile flags excluding windows and mac
prokazov-redis Jan 25, 2023
2ffa362
Actually use conditional compile flags
prokazov Jan 25, 2023
1758fe9
Fix the Windows build.
prokazov-redis Jan 26, 2023
11fa235
Re-factored setup.py and actually fixed the Windows build.
prokazov-redis Jan 26, 2023
d1a5ebe
Apparently 'win' is not the same as win32.
prokazov-redis Jan 26, 2023
493d6a7
Merge branch 'master' into master
chayim Jan 30, 2023
1f1af09
1) Don't use Bsymbolic linker arg
prokazov Jan 31, 2023
02abb23
Merge branch 'master' into Fix-for-Win32-build-break
prokazov Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Actually use conditional compile flags
  • Loading branch information
@prokazov
prokazov committed Jan 25, 2023
commit 2ffa3623733deeabb71f655900fe0409c68d7598
2 changes: 1 addition & 1 deletion setup.py
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def version():
sources=sorted(glob.glob("src/*.c") +
["vendor/hiredis/%s.c" % src for src in ("alloc", "async", "hiredis", "net", "read", "sds")]),
extra_compile_args=["-std=c99"],
extra_link_args=["-Wl,-Bsymbolic"],
extra_link_args=extra_link_args,
include_dirs=["vendor"])

setup(
Expand Down