Run analyze on CI with --strict (#2524)

and whitelist two intentional violations
realm · Dec 24, 2018 · e6ff352 · e6ff352
1 parent 6b78eb4
commit e6ff352
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/Makefile b/Makefile
@@ -63,7 +63,7 @@ write_xcodebuild_log: bootstrap
 	xcodebuild -workspace SwiftLint.xcworkspace -scheme swiftlint > xcodebuild.log
 
 analyze: write_xcodebuild_log
-	swift run -c release swiftlint analyze --compiler-log-path xcodebuild.log
+	swift run -c release swiftlint analyze --strict --compiler-log-path xcodebuild.log
 
 analyze_autocorrect: write_xcodebuild_log
 	swift run -c release swiftlint analyze --autocorrect --compiler-log-path xcodebuild.log

diff --git a/Source/SwiftLintFramework/Extensions/NSRegularExpression+SwiftLint.swift b/Source/SwiftLintFramework/Extensions/NSRegularExpression+SwiftLint.swift
@@ -4,8 +4,12 @@ private var regexCache = [RegexCacheKey: NSRegularExpression]()
 private let regexCacheLock = NSLock()
 
 private struct RegexCacheKey: Hashable {
+    // Disable unused private declaration rule here because even though we don't use these properties
+    // directly, we rely on them for their hashable and equatable behavior.
+    // swiftlint:disable unused_private_declaration
     let pattern: String
     let options: NSRegularExpression.Options
+    // swiftlint:enable unused_private_declaration
 }
 
 extension NSRegularExpression.Options: Hashable {