Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _GetDiskInfo.au3 #486

Closed
wants to merge 1 commit into from
Closed

Update _GetDiskInfo.au3 #486

wants to merge 1 commit into from

Conversation

Oleg-Chashko
Copy link
Contributor

Fixed: Envget -> EnvGet

@Oleg-Chashko
Update _GetDiskInfo.au3
ded959c 
Fixed: Envget -> EnvGet
@htcfreek
Copy link
Contributor

Please don't merge! It's never a good idea to change external includes. And a fix for this exists in a newer version of the included function!

@micwoj92
Copy link
Collaborator

micwoj92 commented Jul 11, 2021 •
edited
Loading

I agree with @htcfreek
especially that this include is still actively developed.

@micwoj92 micwoj92 closed this Jul 11, 2021
@Oleg-Chashko Oleg-Chashko deleted the patch-1 branch July 12, 2021 04:59
@Oleg-Chashko
Copy link
Contributor Author

I'd love to hear what @rcmaehl has to say about this.
Are you guys sure about this?
In the program code, it says EnvGet everywhere as I fixed it.
Should everything be in the same style or not?

Screen Shot 2021-07-12 at 07 02 35

@htcfreek
Copy link
Contributor

The fix for it is in n #488. So it gets fixed hopefully soon.

@Oleg-Chashko Oleg-Chashko restored the patch-1 branch July 12, 2021 06:12
@Oleg-Chashko
Copy link
Contributor Author

The fix for it is in n #488. So it gets fixed hopefully soon.

So what are we changing for: EnvGet -> Envget or Envget -> EnvGet?

@htcfreek
Copy link
Contributor

htcfreek commented Jul 12, 2021 •
edited
Loading

@Oleg-Chashko
Atm we have old and new version in the folder. New file is without _ in it's name.

@Oleg-Chashko
Copy link
Contributor Author

@htcfreek
Thanks, Heiko.

@Oleg-Chashko
Copy link
Contributor Author

@rcmaehl, @micwoj92

Will you open Branch and Merged?
It would be a good idea to correct this typo?

@htcfreek
Copy link
Contributor

htcfreek commented Jul 12, 2021 •
edited
Loading

@rcmaehl, @micwoj92

Will you open Branch and Merged?
It would be a good idea to correct this typo?

Which typo? The g or the duplicate file?

Btw.: Both will be fixed with #488.

@micwoj92
Copy link
Collaborator

@rcmaehl, @micwoj92

Will you open Branch and Merged?
It would be a good idea to correct this typo?

No, for the reasons stated above (#488)
image

@Oleg-Chashko Oleg-Chashko deleted the patch-1 branch July 12, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oleg-Chashko @htcfreek @micwoj92