Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/typescript #69

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

emacsified
Copy link

@emacsified emacsified commented Dec 9, 2020

Hi!
I know I didn't open an issue in advance but wondered whether you'd have any interest in this:

  • Adds typescript support
    • Building implemented via tsc
  • Refactors console.logs to their own function
  • Refactors some anonymous functions to arrow functions
  • Turns some callback functions into async/await.

I'm happy to continue implementing similar changes but wanted to wave this under your noses first!

@emacsified emacsified marked this pull request as draft December 10, 2020 09:24
@emacsified
Copy link
Author

@dotrachit Wanted to ensure you had interest in me continuing down this path before doing any further work, hence why some of the function() calls remain in there

@rchtgpt
Copy link
Owner

rchtgpt commented Dec 10, 2020

@dotrachit Wanted to ensure you had interest in me continuing down this path before doing any further work, hence why some of the function() calls remain in there

Yes, definitely. I'll do a detailed review of the PR in some time, but yes I believe these changes are quite important. @emacsified

@rchtgpt
Copy link
Owner

rchtgpt commented Dec 10, 2020

@emacsified do we really need to refactoring stuff to typescript?

@emacsified
Copy link
Author

@dotrachit That's why I raised this PR as a WIP. It depends on your definition of 'need'!
Typescript can help add to the maintainability of a project, remove bugs etc. But it's really your call as to whether you want it in the repository or not.

If you feel TS is an additional cross you do not wish to bear I'm happy to open a new PR with just the refactoring and no Types

@rchtgpt
Copy link
Owner

rchtgpt commented Dec 10, 2020

@dotrachit That's why I raised this PR as a WIP. It depends on your definition of 'need'!
Typescript can help add to the maintainability of a project, remove bugs etc. But it's really your call as to whether you want it in the repository or not.

If you feel TS is an additional cross you do not wish to bear I'm happy to open a new PR with just the refactoring and no Types

@emacsified Yeah, I don't feel the need to add typescript as of now, considering that we've not received a good enough response from few developers about the project idea. I would love to see you contribute by refactoring the code style and over-used chunks of code because having a good source code is really important. Also, If you're up to discuss the potential use-case and viability of this dev-tool, please write me a mail at guptarachit2004[at]gmail[dot]com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants