-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/typescript #69
base: main
Are you sure you want to change the base?
Feat/typescript #69
Conversation
ddddfcf
to
7d4847e
Compare
@dotrachit Wanted to ensure you had interest in me continuing down this path before doing any further work, hence why some of the |
Yes, definitely. I'll do a detailed review of the PR in some time, but yes I believe these changes are quite important. @emacsified |
@emacsified do we really need to refactoring stuff to typescript? |
@dotrachit That's why I raised this PR as a WIP. It depends on your definition of 'need'! If you feel TS is an additional cross you do not wish to bear I'm happy to open a new PR with just the refactoring and no Types |
@emacsified Yeah, I don't feel the need to add typescript as of now, considering that we've not received a good enough response from few developers about the project idea. I would love to see you contribute by refactoring the code style and over-used chunks of code because having a good source code is really important. Also, If you're up to discuss the potential use-case and viability of this dev-tool, please write me a mail at guptarachit2004[at]gmail[dot]com. |
Hi!
I know I didn't open an issue in advance but wondered whether you'd have any interest in this:
tsc
async/await
.I'm happy to continue implementing similar changes but wanted to wave this under your noses first!