Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The use of LOG macro conflicts with Google logging library #39

Open
Scott-Merritt opened this issue Oct 29, 2021 · 0 comments
Open

The use of LOG macro conflicts with Google logging library #39

Scott-Merritt opened this issue Oct 29, 2021 · 0 comments

Comments

@Scott-Merritt
Copy link

the macro name LOG (defined in Logging.h) is quite commonly used by libraries and is therefore has large potential conflict when integrating multiple libraries into a project.

In particular, the google logging library google-glog, defines LOG as their preferred abbreviated logging form, and this causes conflicts when including both glog/logging.h and rbdl/include/Logging.h from the same source file.

I suggest replacing the LOG macro with RBDL_LOG everywhere within this project to prevent this and other conflicts between libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant