[core] Rename get_timeout_milliseconds to get_check_signal_interval_milliseconds
#49677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
approved these changes
Jan 7, 2025
jjyao
reviewed
Jan 8, 2025
| int64_t batch_timeout = std::max(RayConfig::instance().get_timeout_milliseconds(), | ||
| int64_t(10 * batch_ids.size())); | ||
| int64_t batch_timeout = | ||
| std::max(RayConfig::instance().get_iteration_timeout_milliseconds(), |
There was a problem hiding this comment.
this config is used in multiple places, does get_iteration_timeout reflect all cases?
There was a problem hiding this comment.
Yes, I think so. All of them follow the pattern of using a shorter timeout for each iteration or batch and breaking when certain conditions are met or when a timeout occurs.
…to 20250106-devbox1-tmux-14-ray
kevin85421
changed the title
get_timeout_milliseconds to get_iteration_timeout_millisecondsget_timeout_milliseconds to check_signal_interval_milliseconds
jjyao
reviewed
Jan 9, 2025
src/ray/common/ray_config_def.h
Outdated
| @@ -247,7 +247,7 @@ RAY_CONFIG(uint64_t, raylet_death_check_interval_milliseconds, 1000) | |||
|
|
|||
| /// These are used by the worker to set timeouts and to batch requests when | |||
| /// getting objects. | |||
| RAY_CONFIG(int64_t, get_timeout_milliseconds, 1000) | |||
| RAY_CONFIG(int64_t, check_signal_interval_milliseconds, 1000) | |||
There was a problem hiding this comment.
Suggested change
| RAY_CONFIG(int64_t, check_signal_interval_milliseconds, 1000) | |
| RAY_CONFIG(int64_t, get_check_signal_interval_milliseconds, 1000) |
nit, it's check signal during get.
Can you add a comment as well.
kevin85421
changed the title
get_timeout_milliseconds to check_signal_interval_millisecondsget_timeout_milliseconds to get_check_signal_interval_milliseconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#49444 (comment)
Discuss with @jjyao. Rename
get_timeout_millisecondstocheck_signal_interval_milliseconds.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.