-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Docs do-over (new API stack): Remove all old API stack package_ref
docs.
#49518
[RLlib] Docs do-over (new API stack): Remove all old API stack package_ref
docs.
#49518
Conversation
…_redo_algorithm_configurations
…_redo_key_concepts # Conflicts: # doc/source/rllib/rllib-rlmodule.rst
…_redo_algorithm_configurations
…_redo_cleanup_all_old_api_stack_package_ref Signed-off-by: sven1977 <svenmika1977@gmail.com> # Conflicts: # doc/source/rllib/key-concepts.rst # doc/source/rllib/package_ref/env.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* :py:class:`~ray.rllib.connector.connector_v2.ConnectorV2` (replaces :py:class:`~ray.rllib.connector.connector.Connector` and some of :py:class:`~ray.rllib.evaluation.rollout_worker.RolloutWorker` and :py:class:`~ray.rllib.policy.policy.Policy`) | ||
* :py:class:`~ray.rllib.core.rl_module.rl_module.RLModule` (replaces ``ModelV2`` and ``PolicyMap`` APIs) | ||
* :py:class:`~ray.rllib.core.learner.learner.Learner` (replaces ``RolloutWorker`` and some of ``Policy``) | ||
* :py:class:`~ray.rllib.env.single_agent_episode.SingleAgentEpisode` and :py:class:`~ray.rllib.env.multi_agent_episode.MultiAgentEpisode` (replaces ``ViewRequirement``, ``SampleCollector``, ``Episode``, and ``EpisodeV2``) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When do we use double quotes and when single quotes for code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! :)
I think we should always use double quotes, in the docs ... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, double quotes for code and variables, single quotes only for references, such as:
:py:class:`...`
:ref:`... <>`
`.. <link>`__
:py:meth:`...`
:py:attr:`...`
…ge_ref` docs. (ray-project#49518) Signed-off-by: Roshan Kathawate <roshankathawate@gmail.com>
Docs do-over (new API stack): Remove all old API stack
package_ref
docs.package_ref
where missing.package_ref
changes) not merged yet ...Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.