Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib; setup] Remove unnecessary dependencies from setup.py; add ormsgpack dependency for RLlib #49489

Merged
merged 3 commits into from
Dec 31, 2024
Merged

[RLlib; setup] Remove unnecessary dependencies from setup.py; add ormsgpack dependency for RLlib #49489

merged 3 commits into from
Dec 31, 2024
+1 −8

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Dec 29, 2024 •
edited
Loading

  • Remove unnecessary RLlib dependencies from setup.py (rich, type, scikit-image).
  • Add ormsgpack dependency for RLlib.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
d05e646 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
sven1977
sven1977 commented Dec 29, 2024
View reviewed changes
python/setup.py
@@ -315,11 +315,9 @@ def get_packages(self):
"dm_tree",
"gymnasium==1.0.0",
"lz4",
"scikit-image",
"ormsgpack==1.7.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of 3, add 1 :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sven1977 Do you think we should use ormsgpack for our offline RL API? We use right now msgpack with msgpack-numpy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure yet. This is still in experimental stage. ormsgpack is faster and natively supports numpy. That's good. But msgpack-numpy might produce smaller files. We'll have to see what outweighs what.

simonsays1980
simonsays1980 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Short question in reagrd to offline RL API.

python/setup.py
@@ -315,11 +315,9 @@ def get_packages(self):
"dm_tree",
"gymnasium==1.0.0",
"lz4",
"scikit-image",
"ormsgpack==1.7.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sven1977 Do you think we should use ormsgpack for our offline RL API? We use right now msgpack with msgpack-numpy.

@sven1977 sven1977 added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. rllib RLlib related issues rllib-newstack rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack labels Dec 30, 2024
@sven1977 sven1977 enabled auto-merge (squash) December 30, 2024 18:22
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Dec 30, 2024
@sven1977
removed higher from requirements_compiled.txt (file simply download…
54bbcf2 
…ed from the artifacts tab in buildkite)

Signed-off-by: sven1977 <svenmika1977@gmail.com>
@github-actions github-actions bot disabled auto-merge December 30, 2024 18:50
@sven1977
wip
9ca2b62 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 merged commit d2f9a51 into ray-project:master Dec 31, 2024
5 checks passed
srinathk10 pushed a commit that referenced this pull request Jan 3, 2025
@sven1977 @srinathk10
[RLlib; setup] Remove unnecessary dependencies from setup.py; add `…
5806fdb 
…ormsgpack` dependency for RLlib (#49489)
@sven1977 sven1977 deleted the cleanup_setup_rllib_and_add_ormsgpack_dep branch January 3, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@edoakes edoakes Awaiting requested review from edoakes edoakes is a code owner

@aslonnie aslonnie Awaiting requested review from aslonnie aslonnie is a code owner

Assignees

@simonsays1980 simonsays1980

@richardliaw richardliaw

Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-newstack rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sven1977 @simonsays1980 @richardliaw