[core] Fix gcs member dependency order #49482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <dentinyhao@gmail.com>
dentiny
commented
Dec 29, 2024
| @@ -235,8 +235,8 @@ class GcsNodeManager : public rpc::NodeInfoHandler { | |||
| /// Dead nodes. | |||
| absl::flat_hash_map<NodeID, std::shared_ptr<rpc::GcsNodeInfo>> dead_nodes_; | |||
| /// The nodes are sorted according to the timestamp, and the oldest is at the head of | |||
| /// the list. | |||
| std::list<std::pair<NodeID, int64_t>> sorted_dead_node_list_; | |||
There was a problem hiding this comment.
std::list should be ONLY used when insertion / deletion in the middle is a necessary operation.
jjyao
approved these changes
Dec 29, 2024
justinvyu
pushed a commit
to justinvyu/ray
that referenced
this pull request
Dec 30, 2024
Signed-off-by: dentiny <dentinyhao@gmail.com>
srinathk10
pushed a commit
that referenced
this pull request
Jan 3, 2025
Signed-off-by: dentiny <dentinyhao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes in this PR:
std::dequeinstead ofstd::listto manage dead node list