Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][compiled-graphs] Support wait-and-get to round-robin the acquisition of mutable objects allowing for fast failure #49444

Closed
wants to merge 30 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
e631160
pass tests
kevin85421 Dec 26, 2024
bf585fa
pass tests, refactor
kevin85421 Dec 26, 2024
bf7a26e
pass tests, waitables
kevin85421 Dec 26, 2024
93bff72
update
kevin85421 Dec 26, 2024
d68f8db
pass tests
kevin85421 Dec 27, 2024
aa7b831
pass tests, retrieve obj one by one in sync reader
kevin85421 Dec 27, 2024
a22bbaa
update
kevin85421 Dec 30, 2024
d1aac6c
update comment and move import to top-level
kevin85421 Dec 30, 2024
a84e561
remove logs and update comments for WaitAndGetExperimentalMutableObjects
kevin85421 Dec 30, 2024
9e44591
update comments
kevin85421 Dec 30, 2024
3ddad3a
add some utils
kevin85421 Dec 30, 2024
4ca28e9
fix test_channel tests
kevin85421 Dec 30, 2024
d8dadb4
update
kevin85421 Dec 31, 2024
5d18be7
Merge remote-tracking branch 'upstream/master' into 20241224-2
kevin85421 Dec 31, 2024
cddaef7
fix test_channel
kevin85421 Dec 31, 2024
abd4d28
update type hint
kevin85421 Dec 31, 2024
a684329
remove c++ log
kevin85421 Dec 31, 2024
2a1b3fc
update _read_list
kevin85421 Dec 31, 2024
9a3ae27
refactor
kevin85421 Dec 31, 2024
9f2f1d1
remove comment for visualize tests
kevin85421 Dec 31, 2024
ba489c3
add tests
kevin85421 Dec 31, 2024
ebbee6f
address comments
kevin85421 Dec 31, 2024
8ebe78c
move retrieve_obj_refs to util
kevin85421 Dec 31, 2024
d958b24
fix lint error
kevin85421 Dec 31, 2024
551bacb
fix nccl channel tests
kevin85421 Jan 1, 2025
1ae976b
fix test
kevin85421 Jan 1, 2025
1cc8210
fix typo
kevin85421 Jan 1, 2025
8c4e61d
refactor
kevin85421 Jan 1, 2025
6d22187
Merge remote-tracking branch 'upstream/master' into 20241224-2
kevin85421 Jan 6, 2025
38c8652
fix lint
kevin85421 Jan 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comment and move import to top-level
Signed-off-by: kaihsun <kaihsun@anyscale.com>
  • Loading branch information
kevin85421 committed Dec 30, 2024
commit d1aac6c15b24adaf3a0c619af0aa61afb6ae31c8
2 changes: 1 addition & 1 deletion python/ray/_raylet.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -3437,7 +3437,7 @@ cdef class CoreWorker:
.WaitAndGetExperimentalMutableObjects(
c_object_ids, timeout_ms, num_returns, results))

# Users can determine whether `timeout` was raised by checking the value
# The caller can determine whether `timeout` was raised by checking the value
# of `results`. At the same time, users still want to get the values of some
# objects even if some objects are not ready. Hence, we don't raise
# the exception if `suppress_timeout_errors` is set to True and instead return
Expand Down
4 changes: 1 addition & 3 deletions python/ray/experimental/channel/shared_memory_channel.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import ray.exceptions
from ray import ObjectRef
from ray._raylet import SerializedObject
from ray.experimental.channel import utils
from ray.experimental.channel import ChannelContext, utils
from ray.experimental.channel.common import ChannelInterface, ChannelOutputType
from ray.experimental.channel.intra_process_channel import IntraProcessChannel
from ray.experimental.channel.utils import get_self_actor
Expand Down Expand Up @@ -477,8 +477,6 @@ def read(self, timeout: Optional[float] = None) -> Any:

start_time = time.monotonic()

from ray.experimental.channel import ChannelContext

ctx = ChannelContext.get_current().serialization_context
ret = ctx.get_data(self._local_reader_ref)

Expand Down