Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Setup cgroup v2 in C++ #49416

Merged
merged 23 commits into from
Jan 9, 2025
Merged

[core] Setup cgroup v2 in C++ #49416

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a9e8dc6
setup cgroup v2 in C++
dentiny Dec 23, 2024
feb0282
strinv view for cgroup content
dentiny Dec 24, 2024
ce77002
rename cgroup -> cgroup v2
dentiny Dec 24, 2024
995dc0f
add comment for uuid
dentiny Dec 24, 2024
f54f2eb
minor update in ifdef macro
dentiny Dec 24, 2024
f3a4a9a
raii for cgroup v2
dentiny Dec 24, 2024
341317f
ifdef
dentiny Dec 26, 2024
50874cd
rename as id
dentiny Dec 26, 2024
3027ed8
comment on cgroup class
dentiny Dec 26, 2024
12f0cfe
fix comment
dentiny Dec 26, 2024
c5e3fd7
place process to default cgroup
dentiny Dec 26, 2024
b679ba7
comment to add process to application cgroup
dentiny Dec 27, 2024
7689889
add precondition requirement and fix cleanup logic
dentiny Dec 27, 2024
792fa54
leave TODO for string view
dentiny Dec 27, 2024
128bfdf
remove unused function
dentiny Dec 27, 2024
d3fdd2a
remove useless if branch
dentiny Dec 27, 2024
2dcd1e7
local manager change for cgroup
dentiny Dec 27, 2024
56aeea9
special handle EEXISTS
dentiny Jan 6, 2025
899b27b
Merge branch 'master' into hjiang/cgroup-utils-cpp
dentiny Jan 7, 2025
e15f30d
Merge branch 'master' into hjiang/cgroup-utils-cpp
dentiny Jan 8, 2025
8c0af7f
Merge branch 'master' into hjiang/cgroup-utils-cpp
dentiny Jan 8, 2025
2406936
Merge branch 'master' into hjiang/cgroup-utils-cpp
dentiny Jan 9, 2025
30fc386
Merge branch 'master' into hjiang/cgroup-utils-cpp
dentiny Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
place process to default cgroup 
Signed-off-by: dentiny <dentinyhao@gmail.com>
  • Loading branch information
@dentiny
dentiny committed Dec 26, 2024
commit c5e3fd75a6cfc900a5e55aefa63a8173a801fb50
12 changes: 12 additions & 0 deletions src/ray/common/cgroup/cgroup_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,17 @@ bool RemoveCtxFromDefaultCgroupV2(const PhysicalModeExecutionContext &ctx) {
return true;
}

void PlaceProcessIntoDefaultCgroup(const PhysicalModeExecutionContext &ctx) {
const std::string procs_path =
absl::StrFormat("%s/%s/cgroup.procs", ctx.cgroup_directory, kDefaultCgroupV2Id);
{
std::ofstream out_file{procs_path.data(), std::ios::out};
out_file << ctx.pid;
}

return;
}

} // namespace

/*static*/ std::unique_ptr<CgroupV2Setup> CgroupV2Setup::New(
Expand Down Expand Up @@ -178,6 +189,7 @@ CgroupV2Setup::~CgroupV2Setup() {
const PhysicalModeExecutionContext &ctx) {
// Delete the dedicated cgroup if max memory specified.
if (ctx.max_memory > 0) {
PlaceProcessIntoDefaultCgroup(ctx);
return DeleteCgroupV2(ctx);
}

Expand Down
Loading