Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] Remove detached param from release test #41736

Merged
merged 1 commit into from
Dec 8, 2023
Merged

[serve] Remove detached param from release test #41736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
  • Loading branch information
@edoakes
edoakes committed Dec 8, 2023
commit 0207026420e13d25df4bf8f5e06fcece47de616d
2 changes: 1 addition & 1 deletion release/serve_tests/workloads/serve_test_cluster_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def setup_local_single_node_cluster(
resources={str(i): 2, "proxy": 1},
)
ray.init(address=cluster.address, dashboard_host="0.0.0.0", namespace=namespace)
serve.start(detached=True, proxy_location=DeploymentMode.EveryNode)
serve.start(proxy_location=DeploymentMode.EveryNode)

return _get_global_client(), cluster

Expand Down
Loading