Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-pick][Data] Avoid serializing datasource for Parquet read tasks (#41712) #41725

Merged
merged 1 commit into from
Dec 8, 2023
Merged

[Cherry-pick][Data] Avoid serializing datasource for Parquet read tasks (#41712) #41725

merged 1 commit into from
Dec 8, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Dec 8, 2023 •
edited
Loading

Pick of #41712

Why are these changes needed?

Related issue number

Fixes #41390

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
[Data] Avoid serializing datasource for Parquet read tasks (ray-proje…
589390c 
…ct#41712)

ray-project#41118 added an include_paths parameter to ParquetDatasource. As part of the PR, we pass an self._include_paths attribute to Parquet read tasks.

As a result, the datasource (self) gets serialized with each read tasks. Normally, this isn't an issue, but if you're working with a large dataset (like in the failing release test), then the datasource is slow to serialize.

This PR fixes the issue by removing the reference to self.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani added release-blocker P0 Issue that blocks the release v2.9.0-pick labels Dec 8, 2023
@bveeramani bveeramani changed the title [Data] Avoid serializing datasource for Parquet read tasks (#41712) [Cherry-pick][Data] Avoid serializing datasource for Parquet read tasks (#41712) Dec 8, 2023
@architkulkarni architkulkarni merged commit 0329448 into ray-project:releases/2.9.0 Dec 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@c21 c21 Awaiting requested review from c21 c21 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@Zandew Zandew Awaiting requested review from Zandew Zandew is a code owner

Assignees

@scottjlee scottjlee

@architkulkarni architkulkarni

@zhe-thoughts zhe-thoughts

Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bveeramani @zhe-thoughts @scottjlee @architkulkarni