Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][compiled graphs] Cleanup for DAG context parameters #49051

Open
stephanie-wang opened this issue Dec 3, 2024 · 3 comments · May be fixed by #49565
Open

[core][compiled graphs] Cleanup for DAG context parameters #49051

stephanie-wang opened this issue Dec 3, 2024 · 3 comments · May be fixed by #49565
Assignees
@kevin85421 @dayshah
Labels
beta Beta release feture compiled-graphs enhancement Request for new feature and/or capability

Comments

@stephanie-wang
Copy link
Contributor

Description

There are some confusing names for various DAG context parameters:

  • execution_timeout - actually refers to submission timeout
  • several different parameters related to number of buffered results

We should clean these up before beta release.

Use case

No response
@stephanie-wang stephanie-wang added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Dec 3, 2024
@stephanie-wang stephanie-wang self-assigned this Dec 3, 2024
@stephanie-wang stephanie-wang added beta Beta release feture compiled-graphs and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Dec 3, 2024
@ruisearch42
Copy link
Contributor

The timeout API part is related to this issue: #46935 (comment)

@stephanie-wang stephanie-wang removed their assignment Dec 17, 2024
@kevin85421 kevin85421 self-assigned this Dec 18, 2024
@kevin85421
Copy link
Member

kevin85421 commented Dec 18, 2024 •
edited
Loading

(WIP)

@kevin85421 kevin85421 mentioned this issue Dec 18, 2024
Merged
8 tasks
@ruisearch42
Copy link
Contributor

@dayshah should be able help with some of the tasks.

@kevin85421 kevin85421 mentioned this issue Jan 1, 2025
Merged
8 tasks
@dayshah dayshah assigned dayshah and kevin85421 and unassigned kevin85421 Jan 2, 2025
@dayshah dayshah linked a pull request Jan 3, 2025 that will close this issue
Open
8 tasks
@ruisearch42 ruisearch42 mentioned this issue Jan 6, 2025
Merged
8 tasks
@dayshah dayshah mentioned this issue Jan 6, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin85421 kevin85421

@dayshah dayshah

Labels
beta Beta release feture compiled-graphs enhancement Request for new feature and/or capability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core][cgraph] Remove asyncio_max_queue_size and max_buffered_results dayshah/ray
4 participants
@stephanie-wang @kevin85421 @dayshah @ruisearch42