Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RayJob]: Add RayJob with RayCluster spec e2e test #1636

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

astefanutti
Copy link
Contributor

Why are these changes needed?

This PR adds e2e test following up #1539 and leverages #1575.

It also factorises configuration across the RayJob e2e tests.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@astefanutti astefanutti force-pushed the pr-05 branch 3 times, most recently from b4f2303 to 273772c Compare November 8, 2023 15:22
@astefanutti
Copy link
Contributor Author

@kevin85421 @architkulkarni @z103cb @blublinsky could you please review, thanks.

@architkulkarni architkulkarni self-assigned this Nov 13, 2023
Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just one question, why hardcode the submitterPodTemplate in the test instead of just not specifying it and letting the RayJob controller fill in the default?

@astefanutti
Copy link
Contributor Author

astefanutti commented Nov 14, 2023

Just one question, why hardcode the submitterPodTemplate in the test instead of just not specifying it and letting the RayJob controller fill in the default?

The compute resources in the default submitter Pod template are a bit too large to bin-pack resources in KinD, so submitterPodTemplate is set with one that has smaller requests and limits, so it accommodates GH Actions VM limited resources.

@architkulkarni architkulkarni merged commit 1c5f3e8 into ray-project:master Nov 14, 2023
blublinsky pushed a commit to blublinsky/kuberay that referenced this pull request Nov 16, 2023
This PR adds e2e test following up ray-project#1539 and leverages ray-project#1575.

It also factorises configuration across the RayJob e2e tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants