Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[RayJob]: Disable job submission retry for now
Browse files Browse the repository at this point in the history
astefanutti committed Oct 18, 2023
1 parent f2b7ce0 commit 62519ac
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion ray-operator/controllers/ray/rayjob_controller.go
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/client-go/tools/record"
"k8s.io/utils/pointer"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
@@ -412,7 +413,10 @@ func (r *RayJobReconciler) createNewK8sJob(ctx context.Context, rayJobInstance *
},
},
Spec: batchv1.JobSpec{
Template: submitterTemplate,
// The `ray job submit` command fails when submission is retried with the same job ID.
// Let's disable backoff retry, until job submission retry effectively works.
BackoffLimit: pointer.Int32(0),
Template: submitterTemplate,
},
}

0 comments on commit 62519ac

Please sign in to comment.