Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index out of Range after Download #467

Closed
HelloKitty opened this issue Jul 2, 2021 · 3 comments · Fixed by #468
Closed

Index out of Range after Download #467

HelloKitty opened this issue Jul 2, 2021 · 3 comments · Fixed by #468

Comments

@HelloKitty
Copy link
Contributor

After downloading a zip file from AzureBlob SAS URL it seems to fail with a non-descript Index out of Range. With no stack trace and I don't see a way to catch the exception to get more information related to it.
@HelloKitty
Copy link
Contributor Author

HelloKitty commented Jul 2, 2021 •
edited
Loading

Update: Setting Content-Disposition to "inline" on the Azure blob mitigates this issue. But why is explicit setting of the Content-Disposition required?

Azure seems to set Content-Disposition header to an empty string if not explicitly defined. I believe this is why it fails to extract.

HelloKitty added a commit to HelloKitty/AutoUpdater.NET that referenced this issue Jul 2, 2021
@HelloKitty
Treat Empty ContentDisposition header as null
b50b4f2 
Maybe fixes: ravibpatel#467
@HelloKitty HelloKitty mentioned this issue Jul 2, 2021
Merged
@ravibpatel
Copy link
Owner

You can test it by downloading the latest build from here.

@HelloKitty
Copy link
Contributor Author

@ravibpatel This appears to resolve the issue. Either #468 or some other change in-between 1.6.4 to 1.7.x seems to fix the issue related to an empty ContentDisposition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Treat Empty ContentDisposition header as null HelloKitty/AutoUpdater.NET
2 participants
@ravibpatel @HelloKitty