Skip to content

Commit

Permalink
build: bump msrv to 1.63
Browse files Browse the repository at this point in the history
  • Loading branch information
joshka committed Nov 12, 2024
1 parent 402d370 commit 0873a58
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 12 deletions.
10 changes: 3 additions & 7 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,9 @@ jobs:
RUSTDOCFLAGS: --cfg docsrs
msrv:
# check that we can build using the minimal rust version that is specified by this crate
name: Check MSRV (1.61)
name: Check MSRV (1.63)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install Rust 1.61
uses: dtolnay/rust-toolchain@master
with:
toolchain: "1.61"
- name: cargo +1.61 check
run: cargo check
- uses: dtolnay/rust-toolchain@1.63
- run: cargo +1.63 check
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ repository = "https://github.com/ratatui-org/instability"
documentation = "https://docs.rs/instability/"
readme = "README.md"
edition = "2021"
rust-version = "1.61"
rust-version = "1.63"

[dependencies]
darling = "0.20.10"
Expand Down
8 changes: 4 additions & 4 deletions example/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@ impl UnstableStruct {
/// A stable method
///
/// This method is stable
#[expect(
#[allow(
unreachable_pub,
reason = "The unstable macros cannot make the method pub(crate)"
// reason = "The unstable macros cannot make the method pub(crate)"
)]
pub fn stable_method(&self) {
unimplemented!()
Expand Down Expand Up @@ -249,7 +249,7 @@ pub use private::private_function as stable_reexport;
///
/// This re-export is unstable.
#[instability::unstable(feature = "reexport")]
#[expect(unused_imports)]
#[allow(unused_imports)]
pub use private::private_function as unstable_reexport;

// This does not work as the unstable_private_function is only public within the crate and cannot
Expand All @@ -265,5 +265,5 @@ pub use private::private_function as unstable_reexport;
/// section of the unstable_private_function, which will look odd. Consider avoiding re-exporting
/// unstable items like this, and instead only mark the re-export itself as unstable.
#[instability::unstable(feature = "reexport")]
#[expect(unused_imports)]
#[allow(unused_imports)]
pub use private::unstable_private_function as unstable_unstable_export;

0 comments on commit 0873a58

Please sign in to comment.