Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotation project deserializer and process_upload.py #5356

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

Lknechtli
Copy link
Contributor

@Lknechtli Lknechtli commented Mar 11, 2020

Overview

see title

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible
  • Swagger specification updated
  • New tables and queries have appropriate indices added
  • Any content changes are properly templated using BUILDCONFIG.APP_NAME
  • Any new SQL strings have tests
  • Any new endpoints have scope validation and are included in the integration test csv

Notes

Changed "status" to "progressStage" inside the status object, since status: {"status": ...} is silly

Testing Instructions

Copy link
Contributor

@jisantuc jisantuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked using an upgrade from local annotate.

I did test both a successful and unsuccessful upload with the changes from review in the previous pr, so I'm not sure what broke, but it seems fine now, so 🤷‍♂️

@Lknechtli Lknechtli merged commit acc320e into develop Mar 11, 2020
@Lknechtli Lknechtli deleted the feature/lk/fix-annotation-project-model-changes branch March 11, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants