-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook up async tasks to new AnnotationProject.status field #5350
Hook up async tasks to new AnnotationProject.status field #5350
Conversation
db53fce
to
65957fa
Compare
app-backend/datamodel/src/main/scala/AnnotationProjectStatus.scala
Outdated
Show resolved
Hide resolved
app-backend/datamodel/src/main/scala/AnnotationProjectStatus.scala
Outdated
Show resolved
Hide resolved
changelog wip address comments formatting, add .env.local to gitignore
9909382
to
4cbfb32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small changes around how the api interaction with python works (objects instead of strings for the failures) and how the decoder for the success cases works, but it's small stuff and I don't need to review again after CI passes (only change to make outside of suggestions is importing scala.util.Try
). Works great otherwise 🎉
app-backend/datamodel/src/main/scala/AnnotationProjectStatus.scala
Outdated
Show resolved
Hide resolved
Co-Authored-By: James Santucci <james.santucci@gmail.com>
Overview
Add a more informative status field to annotation projects
Migrate from the ready field to a status field
Set statuses correctly in upload processing
Checklist
Swagger specification updatedAny content changes are properly templated usingBUILDCONFIG.APP_NAME
Any new SQL strings have testsAny new endpoints have scope validation and are included in the integration test csvDemo
Statuses as set by raising exceptions in the appropriate sections of the upload batch process:
Notes
Error handling does not encompass larger scale batch issues (unable to contact API, etc), since we don't have a good way of handling that right now. This should be handled in a later issue
Testing Instructions
select id from uploads where annotation_project_id = '<annotation_project_id>';
./scripts/console batch 'AWS_BATCH_JOB_ATTEMPT=3 rf process-upload 819c2ce5-e48a-40c3-8a27-f274b1ec4e59'
try
catch block, rebuild the batch container, and re-run the batch command. Verify that it sets the status toIMAGE_INGESTION_FAILURE
TaskGridError
there instead and verify it sets the status toTASK_GRID_FAILURE
Closes https://github.com/raster-foundry/annotate/issues/670