Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLS data publications views #1532 #1533 #1538

Open
wants to merge 34 commits into
base: develop
Choose a base branch
from
Open

DLS data publications views #1532 #1533 #1538

wants to merge 34 commits into from

Conversation

louise-davies
Copy link
Member

Description

Adding the DOI landing pages, which have a details tab & a content tab which shows the investigations, datasets and datafiles contained in the data publication. Also adds the My DOI view, which has a table of the DOIs the logged in user has minted.

See screenshots:

dls_doi_landing_page

dls_doi_landing_page_content

dls_my_dois

It's still a WIP - I haven't written any tests and I still have some strings hard coded instead of put in the default.json - but I figured these are a lesser priority than just getting a working feature out. There's also a few TODOs still - I need to sort out the breadcrumbs on the DLS DOI landing pages, and there's a visual bug with the content table if you switch from Datasets to one of the other tabs when that tab is empty and then switch back to datasets.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • Deploy with other PR & Alex's minting backend to test the DOI minting workflow

Agile board tracking

Closes #1532, Closes #1533

@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.85981% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 96.24%. Comparing base (03624bf) to head (d715a0d).

❗ Current head d715a0d differs from pull request most recent head 5cbd215. Consider uploading reports for the commit 5cbd215 to get more accurate results

Files Patch % Lines
...g/dls/dlsDataPublicationContentTable.component.tsx 92.30% 5 Missing ⚠️
...es/datagateway-common/src/api/dataPublications.tsx 88.88% 4 Missing ⚠️
...w/src/views/table/dls/dlsMyDOIsTable.component.tsx 92.30% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1538      +/-   ##
===========================================
- Coverage    96.25%   96.24%   -0.02%     
===========================================
  Files          170      165       -5     
  Lines         7326     7076     -250     
  Branches      2330     2181     -149     
===========================================
- Hits          7052     6810     -242     
+ Misses         254      246       -8     
  Partials        20       20
Flag Coverage Δ
common 95.44% <90.00%> (+0.12%) ⬆️
dataview 96.79% <95.97%> (-0.58%) ⬇️
download 96.84% <ø> (+0.85%) ⬆️
search 96.50% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louise-davies louise-davies marked this pull request as ready for review July 28, 2023 13:04
@louise-davies louise-davies requested review from patrick-austin and removed request for moonraker595 August 4, 2023 09:53
@louise-davies
Copy link
Member Author

TODO: add versioning panel to both concept & version landing pages

Also might need to filter out version DOIs somehow from the table view

Also need to add an edit button to landing pages to create new versions (need to think which DOI pages provide this button e.g. only latest version allows editing? does the concept get to be edited?)

Check SEO stuff?

Might need to check versioning redirect stuff

@louise-davies louise-davies added the WIP This PR is still being worked on and should not merged label Dec 12, 2023
@louise-davies louise-davies force-pushed the feature/dls-data-publications-#1532-#1533 branch from d4fccfe to 729e0e3 Compare March 15, 2024 15:52
@louise-davies
#1532 - adjust concept/version DOI stuff
490d6aa 
- Add dates to versioning panel & ensure we order by createTime
- Show latest version DOI more prominently
- Remove concept panel in favour of concept short info item
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 93.25843% with 42 lines in your changes missing coverage. Please review.

Project coverage is 96.11%. Comparing base (03624bf) to head (7a65d00).
Report is 14 commits behind head on develop.

Files Patch % Lines
packages/datagateway-common/src/api/dois.tsx 82.82% 16 Missing and 1 partial ⚠️
...es/datagateway-common/src/api/dataPublications.tsx 83.33% 8 Missing ⚠️
...nding/dls/dlsDataPublicationEditForm.component.tsx 93.40% 6 Missing ⚠️
...g/dls/dlsDataPublicationContentTable.component.tsx 92.30% 5 Missing ⚠️
...mon/src/dois/creatorsAndContributors.component.tsx 80.00% 3 Missing ⚠️
...ateway-dataview/src/page/pageRouting.component.tsx 80.00% 1 Missing ⚠️
...w/src/views/table/dls/dlsMyDOIsTable.component.tsx 95.83% 1 Missing ⚠️
packages/datagateway-download/src/App.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1538      +/-   ##
===========================================
- Coverage    96.25%   96.11%   -0.15%     
===========================================
  Files          170      179       +9     
  Lines         7326     7806     +480     
  Branches      2330     2485     +155     
===========================================
+ Hits          7052     7503     +451     
- Misses         254      281      +27     
- Partials        20       22       +2
Flag Coverage Δ
common 94.91% <84.78%> (-0.42%) ⬇️
dataview 97.28% <96.89%> (-0.08%) ⬇️
download 96.06% <95.00%> (+0.07%) ⬆️
search 96.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louise-davies
Copy link
Member Author

We need to allow for the API urls to be configured by env variables in a Docker container

@louise-davies
Copy link
Member Author

Also, need to add something like this to the default settings:

{
      "section": "Browse",
      "link": "/browse/dataPublication",
      "displayName": "DLS DataPublications",
      "order": 8,
      "hideFromMenu": true
},

@akintomiwa akintomiwa mentioned this pull request Aug 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick-austin patrick-austin Awaiting requested review from patrick-austin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
WIP This PR is still being worked on and should not merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add My DOIs view Add DLS DOI landing page
2 participants
@louise-davies @codecov-commenter