Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download tables sort by requested time descending by default #1176 #1226

Merged

Conversation

sam-glendenning
Copy link
Contributor

@sam-glendenning sam-glendenning commented Apr 19, 2022

Description

Whenever the user navigates to the download status tables, they are now sorted by download requested time descending. This change affects both user download status table and admin download status tables.

Testing instructions

Check unit and e2e tests carefully to make sure changes are correct. When trying the changes yourself, navigate back and forth from the download tables with multiple sorts applied to make sure that every navigation back shows the default sort as requested time descending.

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Closes #1176

@sam-glendenning sam-glendenning added enhancement New feature or request datagateway-download Issues relating to the download plugin user feedback Issues that were raised by users labels Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1226 (68acecb) into develop (26e5726) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1226   +/-   ##
========================================
  Coverage    97.78%   97.78%           
========================================
  Files          132      132           
  Lines         6736     6736           
  Branches      1984     1984           
========================================
  Hits          6587     6587           
  Misses         136      136           
  Partials        13       13           
Flag Coverage Δ
common 98.12% <ø> (ø)
dataview 98.01% <ø> (ø)
download 96.78% <100.00%> (ø)
search 97.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nloadStatus/adminDownloadStatusTable.component.tsx 98.94% <100.00%> (ø)
...c/downloadStatus/downloadStatusTable.component.tsx 97.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e5726...68acecb. Read the comment docs.

Copy link
Member

@louise-davies louise-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@sam-glendenning sam-glendenning merged commit 3cb1ca2 into develop Apr 20, 2022
@sam-glendenning sam-glendenning deleted the feature/order-downloads-by-requested-date-#1176 branch April 20, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datagateway-download Issues relating to the download plugin enhancement New feature or request user feedback Issues that were raised by users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order downloads by Requested Date by default
2 participants