chore: inline rolldown package dependencies (rolldown#1527)

raincamp · Jul 5, 2024 · 5da6f32 · 5da6f32
1 parent f0de5f8
commit 5da6f32
Showing 3 changed files with 23 additions and 25 deletions.
diff --git a/packages/rolldown/package.json b/packages/rolldown/package.json
@@ -92,17 +92,17 @@
     "dtsHeader": "type MaybePromise<T> = T | Promise<T>\ntype Nullable<T> = T | null | undefined\ntype VoidNullable<T = void> = T | null | undefined | void\n"
   },
   "dependencies": {
-    "citty": "^0.1.6",
-    "colorette": "^2.0.20",
-    "consola": "^3.2.3",
-    "locate-character": "^3.0.0",
-    "mri": "^1.2.0",
     "zod": "^3.23.8"
   },
   "devDependencies": {
     "@napi-rs/cli": "^3.0.0-alpha.55",
     "@napi-rs/wasm-runtime": "^0.2.4",
     "@rolldown/testing": "workspace:*",
+    "citty": "^0.1.6",
+    "colorette": "^2.0.20",
+    "consola": "^3.2.3",
+    "locate-character": "^3.0.0",
+    "mri": "^1.2.0",
     "emnapi": "^1.2.0",
     "execa": "^9.2.0",
     "fs-extra": "^11.2.0",

diff --git a/packages/rolldown/rolldown.config.mjs b/packages/rolldown/rolldown.config.mjs
@@ -21,11 +21,9 @@ const shared = defineConfig({
     /rolldown-binding\..*\.wasm/,
     /@rolldown\/binding-.*/,
     /\.\/rolldown-binding\.wasi\.cjs/,
-    ...Object.keys(pkgJson.dependencies).filter(
-      (dep) =>
-        // `locate-character` only exports esm. to support emitting rolldown of cjs version, we have to inline it.
-        dep !== 'locate-character',
-    ),
+    // some dependencies, e.g. zod, cannot be inlined because their types
+    // are used in public APIs
+    ...Object.keys(pkgJson.dependencies),
   ],
 })
 

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml