Configure tests to run inside a Docker container #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wpolicarpo the failures here, am I correct that these are Rails 5.2 issues rather than problems created by the introduction of docker? |
|
@thomasfedb you're right, those errors are part of the Rails 5.2 changes. These docker images came to solve one specific problem: freetds and openssl installation, which was causing a lot of builds to fail because those FTP addresses were down/intermittent. #662 will address Rails 5.2 regressions, but I'd like to have a more stable CI first and that's why I created these images. |
thomasfedb
reviewed
Dec 3, 2018
thomasfedb
reviewed
Dec 3, 2018
|
@metaskills are you ok with this change? Also, I'm not sure why, but |
aharpervc
reviewed
Dec 19, 2018
|
Rebased onto |
|
@aharpervc do you think this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's no uncommon to see tests failing because FreeTDS could not be installed due to ftp issues. In order to mitigate this issue, I created a Docker image with all dependencies installed so we can use to run tests.
Dockerfile can be found here.
I'm happy to move Dockerfile source code to https://github.com/rails-sqlserver/docker-images if necessary.