Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rails 5.2] Fix failing tests #662

Merged
merged 20 commits into from
Jan 23, 2019
Merged

[Rails 5.2] Fix failing tests #662

merged 20 commits into from
Jan 23, 2019

Conversation

wpolicarpo
Copy link
Member

@wpolicarpo wpolicarpo commented Oct 11, 2018 •
edited
Loading

This PR aims to fix master tests so we can release a version compatible with Rails 5.2.

This was referenced Oct 11, 2018
Closed
Closed
@wpolicarpo wpolicarpo changed the title [Rails 5.2] Fix failing tests [wip] [Rails 5.2] Fix failing tests Oct 15, 2018
@thomasfedb
Copy link

This appears to fail on CI due to FTP issues with FreeTDS. @wpolicarpo does this pass otherwise?

This was referenced Dec 3, 2018
Merged
Closed
@rhuanbarreto
Copy link
Contributor

PR #666 fix the ftp issue

@wpolicarpo
Fix isolation level reset
3b0a8aa
@wpolicarpo
Fix failing ActiveRecord::RelationTest tests
90ad1a9
@wpolicarpo
Update supported ruby versions
0e57444
@wpolicarpo
Fix flaky InstrumentationTest
bab2d13
@wpolicarpo
Set Connection#bind_params_length to 2100
12affbb
@wpolicarpo
Decrease the max number of binds to 2098
b3e40d5
@wpolicarpo
Limit fixture insert to 1000 rows
08ca816 
SQL Server has a limit of 1000 rows per insert statement. ActiveRecord does not
expose a configuration so adapters can set this limit by themselves.

This change creates a new config entry and apply the limit fixtures creation.
@wpolicarpo
Fix datetime precision tests
bddcb60
@wpolicarpo
Remove ruby 2.2 in favour of 2.6
26202c4
@wpolicarpo
Fix RelationMerging test case
cbd5e89
@wpolicarpo
Decrease in_clause_length to 10k
159346e
@wpolicarpo
Coerce test_eager_loading_too_may_ids due to rails issue
6b08105
@wpolicarpo
Fix datetime precision regression
603f2fb
@wpolicarpo
Fix average calculation in ruby 2.6
05f13db 
Ruby 2.6 added `to_d` to BigDecimal and it was causing some tests
to fail because of that.

See rails/rails#34858
@wpolicarpo
Add back supports_savepoints? returning true
e1938c3
@wpolicarpo
Add label to travis matrix
9626a12
@wpolicarpo
Better sqlserver version memoization
fdfa5a0
@wpolicarpo
Fix flaky migration test
1fb5b8c
@wpolicarpo
Do not cache internal introspection queries
397479b
@wpolicarpo wpolicarpo changed the title [wip] [Rails 5.2] Fix failing tests [Rails 5.2] Fix failing tests Jan 18, 2019
@wpolicarpo
Copy link
Member Author

@metaskills CI is green again. Do you want to have a look?

@wpolicarpo wpolicarpo merged commit 37e1925 into rails-sqlserver:master Jan 23, 2019
@wpolicarpo wpolicarpo deleted the fix-master-tests branch January 24, 2019 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-5.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wpolicarpo @thomasfedb @rhuanbarreto