New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rails 5.2] Fix failing ActiveRecord::RelationTest tests #660

Closed

wpolicarpo wants to merge 1 commit into rails-sqlserver:master from wpolicarpo:fix-relation-tests

Member

wpolicarpo commented Oct 1, 2018 •

edited

Loading

This PR fixes one of the failing tests after 5.2 work was merged to master:

https://circleci.com/gh/rails-sqlserver/activerecord-sqlserver-adapter/209


          Fix failing ActiveRecord::RelationTest tests

d79e41f

wpolicarpo changed the title ~~Fix failing ActiveRecord::RelationTest tests~~ [Rails 5.2] Fix failing ActiveRecord::RelationTest tests

wpolicarpo mentioned this pull request

Upgrade to Rails 5.2 #653

Merged

2 tasks

aidanharan mentioned this pull request

Coerce ActiveRecord test as table name wasn't being escaped #661

Closed

Member Author

wpolicarpo commented Oct 11, 2018

Closing this in favour of #662.

wpolicarpo closed this

wpolicarpo deleted the fix-relation-tests branch

January 14, 2019 22:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet