-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling fields option to json adapter #999
Closed
joaomdmoura
wants to merge
5
commits into
rails-api:master
from
joaomdmoura:enabling-fields-option-to-json-adapter
Closed
Enabling fields option to json adapter #999
joaomdmoura
wants to merge
5
commits into
rails-api:master
from
joaomdmoura:enabling-fields-option-to-json-adapter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomdmoura
force-pushed
the
enabling-fields-option-to-json-adapter
branch
from
July 23, 2015 06:19
11169eb
to
c559052
Compare
Rebased with master, now with |
This was referenced Jul 31, 2015
joaomdmoura
force-pushed
the
enabling-fields-option-to-json-adapter
branch
from
July 31, 2015 14:59
c559052
to
21352c0
Compare
joaomdmoura
force-pushed
the
enabling-fields-option-to-json-adapter
branch
from
August 17, 2015 06:41
21352c0
to
53d5915
Compare
ref: #1058 |
It does not seems to receive a lot of back up so I'm closing it as well in favor of #1058 |
I can't believe it that this was never merged :) The API for fields was excellent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fix #992
fields
option was used on Json API adapter but never on Json adapter. This implements thefields
option on it.It enables you to filter the fields you want on
render
method call: