Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store canonical recurring tasks in the DB #272

Merged
merged 11 commits into from
Aug 7, 2024
Merged

Store canonical recurring tasks in the DB #272

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7e2b5d1
Convert recurring tasks into Active Records
rosa Jul 19, 2024
49ae908
Serialize recurring task's arguments using a custom coder
rosa Jul 19, 2024
bf420f1
Use Active Model validations and validate class name as well
rosa Jul 19, 2024
546aaa6
Add `static` attribute to recurring tasks
rosa Jul 20, 2024
6236739
Persist and reload recurring tasks before scheduling them
rosa Aug 2, 2024
04a1d93
Fix persisting tasks for PostgreSQL on concurrent INSERTs
rosa Aug 2, 2024
09eabe2
Allow specifying queue, priority, command and description for recurri…
rosa Aug 5, 2024
d1676d5
Add upgrading instructions for the upcoming version
rosa Aug 5, 2024
845d36e
Handle concurrent inserts in PostgreSQL when enqueuing recurring tasks
rosa Aug 5, 2024
c2ec696
Improve tests in preparation for bumping Rails dependency
rosa Aug 5, 2024
953349c
Don't delete persisted recurring tasks when the dispatcher shuts down
rosa Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow specifying queue, priority, command and description for recurri… 
…ng tasks

These will be used later on.
  • Loading branch information
@rosa
rosa committed Aug 6, 2024
commit 09eabe2c8f79c3e6e3769b6591042372aef4e776
8 changes: 7 additions & 1 deletion db/migrate/20240719134516_create_recurring_tasks.rb
View file
Original file line number Diff line number Diff line change
@@ -3,11 +3,17 @@ def change
create_table :solid_queue_recurring_tasks do |t|
t.string :key, null: false, index: { unique: true }
t.string :schedule, null: false
t.string :class_name, null: false
t.string :command, limit: 2048
t.string :class_name
t.text :arguments

t.string :queue_name
t.integer :priority, default: 0

t.boolean :static, default: true, index: true

t.text :description

t.timestamps
end
end
6 changes: 5 additions & 1 deletion test/dummy/db/schema.rb
View file
Original file line number Diff line number Diff line change
@@ -104,9 +104,13 @@
create_table "solid_queue_recurring_tasks", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t|
t.string "key", null: false
t.string "schedule", null: false
t.string "class_name", null: false
t.string "command", limit: 2048
t.string "class_name"
t.text "arguments"
t.string "queue_name"
t.integer "priority", default: 0
t.boolean "static", default: true
t.text "description"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.index ["key"], name: "index_solid_queue_recurring_tasks_on_key", unique: true