From ce921b2e0ad8b7955def5ffa72702e8f44a74998 Mon Sep 17 00:00:00 2001 From: Jean Boussier Date: Wed, 17 Apr 2024 11:24:27 +0200 Subject: [PATCH] Hard fail ruby nigthly jobs Now that it's in a separate pipeline, it doesn't make much sense to soft fail it, as it makes it harder to notice ruby-head has failures from the build list. --- lib/buildkite/config/ruby_config.rb | 6 +++--- test/buildkite_config/test_rake_command.rb | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/buildkite/config/ruby_config.rb b/lib/buildkite/config/ruby_config.rb index 84073c80..a82832a8 100644 --- a/lib/buildkite/config/ruby_config.rb +++ b/lib/buildkite/config/ruby_config.rb @@ -7,17 +7,17 @@ class RubyConfig class << self def master_ruby - new(version: MASTER_RUBY_IMAGE, soft_fail: true) + new(version: MASTER_RUBY_IMAGE) end def master_debug_ruby - new(version: MASTER_DEBUG_RUBY_IMAGE, soft_fail: true) + new(version: MASTER_DEBUG_RUBY_IMAGE) end def yjit_ruby # Adds yjit: onto the master ruby image string so we # know when to turn on YJIT via the environment variable. - new(version: "yjit:#{MASTER_RUBY_IMAGE}", soft_fail: true, yjit: true) + new(version: "yjit:#{MASTER_RUBY_IMAGE}", yjit: true) end end diff --git a/test/buildkite_config/test_rake_command.rb b/test/buildkite_config/test_rake_command.rb index 36a1e5ab..f4f9ae9e 100644 --- a/test/buildkite_config/test_rake_command.rb +++ b/test/buildkite_config/test_rake_command.rb @@ -292,8 +292,7 @@ def test_env_yjit assert_includes pipeline.to_h["steps"][0]["env"], "RUBY_YJIT_ENABLE" assert_equal "1", pipeline.to_h["steps"][0]["env"]["RUBY_YJIT_ENABLE"] - assert_includes pipeline.to_h["steps"][0], "soft_fail" - assert_equal true, pipeline.to_h["steps"][0]["soft_fail"] + assert_not_includes pipeline.to_h["steps"][0], "soft_fail" end def test_env_pre_steps