Hard fail ruby nigthly jobs

Now that it's in a separate pipeline, it doesn't make much sense to soft fail it, as it makes it harder to notice ruby-head has failures from the build list.
rails · Apr 17, 2024 · ce921b2 · ce921b2
1 parent 724de9d
commit ce921b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/lib/buildkite/config/ruby_config.rb b/lib/buildkite/config/ruby_config.rb
@@ -7,17 +7,17 @@ class RubyConfig
 
     class << self
       def master_ruby
-        new(version: MASTER_RUBY_IMAGE, soft_fail: true)
+        new(version: MASTER_RUBY_IMAGE)
       end
 
       def master_debug_ruby
-        new(version: MASTER_DEBUG_RUBY_IMAGE, soft_fail: true)
+        new(version: MASTER_DEBUG_RUBY_IMAGE)
       end
 
       def yjit_ruby
         # Adds yjit: onto the master ruby image string so we
         # know when to turn on YJIT via the environment variable.
-        new(version: "yjit:#{MASTER_RUBY_IMAGE}", soft_fail: true, yjit: true)
+        new(version: "yjit:#{MASTER_RUBY_IMAGE}", yjit: true)
       end
     end
 

diff --git a/test/buildkite_config/test_rake_command.rb b/test/buildkite_config/test_rake_command.rb
@@ -292,8 +292,7 @@ def test_env_yjit
     assert_includes pipeline.to_h["steps"][0]["env"], "RUBY_YJIT_ENABLE"
     assert_equal "1", pipeline.to_h["steps"][0]["env"]["RUBY_YJIT_ENABLE"]
 
-    assert_includes pipeline.to_h["steps"][0], "soft_fail"
-    assert_equal true, pipeline.to_h["steps"][0]["soft_fail"]
+    assert_not_includes pipeline.to_h["steps"][0], "soft_fail"
   end
 
   def test_env_pre_steps