Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add secrets to crate token (#2046) #2048

Merged
merged 6 commits into from
Jan 13, 2025
Merged

ci: Add secrets to crate token (#2046) #2048

merged 6 commits into from
Jan 13, 2025

Conversation

alpeto9
Copy link
Contributor

@alpeto9 alpeto9 commented Jan 8, 2025

Summary

  • ci: Add secrets related with crate token in ci.yml file

@alpeto9 alpeto9 requested review from a team January 8, 2025 09:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

Docker tags
docker.io/radixdlt/private-scrypto-builder:50114e4fa2

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

Docker tags
docker.io/radixdlt/private-scrypto-dev-container:50114e4fa2

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

Benchmark for 50114e4

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.4±0.18ms 44.4±0.07ms 0.00%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.9±0.06ms 19.6±0.04ms -1.51%
costing::decode_encoded_i8_array_to_manifest_value 40.8±0.14ms 42.5±0.18ms +4.17%
costing::decode_encoded_tuple_array_to_manifest_raw_value 72.0±0.13ms 72.1±0.22ms +0.14%
costing::decode_encoded_tuple_array_to_manifest_value 99.1±0.27ms 123.1±1.22ms +24.22%
costing::decode_encoded_u8_array_to_manifest_raw_value 32.5±0.14µs 25.6±0.07µs -21.23%
costing::decode_encoded_u8_array_to_manifest_value 40.9±0.16ms 42.5±0.18ms +3.91%
costing::decode_rpd_to_manifest_raw_value 14.6±0.02µs 14.9±0.06µs +2.05%
costing::decode_rpd_to_manifest_value 10.8±0.27µs 10.7±0.04µs -0.93%
costing::deserialize_wasm 1210.1±2.94µs 1224.4±7.58µs +1.18%
costing::execute_transaction_creating_big_vec_substates 691.3±3.47ms 708.0±9.05ms +2.42%
costing::execute_transaction_reading_big_vec_substates 590.7±1.51ms 372.5±1.50ms -36.94%
costing::instantiate_flash_loan 895.3±304.86µs 843.7±214.56µs -5.76%
costing::instantiate_radiswap 937.1±786.53µs 962.2±906.52µs +2.68%
costing::scrypto_malloc 662.0±1.08ms 656.4±1.22ms -0.85%
costing::scrypto_sbor_decode 657.0±0.81ms 654.5±1.11ms -0.38%
costing::scrypto_sha256 585.7±1.06ms 585.6±1.13ms -0.02%
costing::spin_loop_v1 512.5±1.34ms 522.2±5.68ms +1.89%
costing::spin_loop_v2 601.5±2.55ms 601.6±1.23ms +0.02%
costing::validate_sbor_payload 29.6±0.10µs 30.9±0.10µs +4.39%
costing::validate_sbor_payload_bytes 247.8±1.59ns 250.4±0.99ns +1.05%
costing::validate_secp256k1 76.7±0.09µs 76.6±0.18µs -0.13%
costing::validate_wasm 33.4±0.04ms 33.4±0.04ms 0.00%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 314.3±3.27ns 321.8±1.70ns +2.39%
decimal::add/wasmi-call-native 3.0±0.00µs 3.0±0.01µs 0.00%
decimal::div/0 168.6±0.14ns 168.2±0.18ns -0.24%
decimal::from_string/0 156.9±0.06ns 156.9±0.10ns 0.00%
decimal::mul/0 129.4±0.08ns 129.3±0.06ns -0.08%
decimal::mul/rust-native 128.5±0.31ns 128.0±0.32ns -0.39%
decimal::mul/wasmi 19.5±0.06µs 19.5±0.02µs 0.00%
decimal::mul/wasmi-call-native 3.1±0.00µs 3.2±0.00µs +3.23%
decimal::pow/0 592.3±0.40ns 593.7±0.34ns +0.24%
decimal::pow/rust-native 591.7±0.32ns 592.3±0.44ns +0.10%
decimal::pow/wasmi 92.8±0.17µs 92.4±0.09µs -0.43%
decimal::pow/wasmi-call-native 4.9±0.00µs 4.9±0.00µs 0.00%
decimal::root/0 8.0±0.01µs 8.2±0.02µs +2.50%
decimal::sub/0 8.2±0.06ns 8.2±0.00ns 0.00%
decimal::to_string/0 445.2±0.56ns 454.4±0.77ns +2.07%
large_transaction_processing::prepare 2.5±0.00ms 2.6±0.00ms +4.00%
large_transaction_processing::prepare_and_decompile 6.3±0.02ms 6.4±0.02ms +1.59%
large_transaction_processing::prepare_and_decompile_and_recompile 27.7±2.45ms 29.5±3.25ms +6.50%
metadata_validation::validate_urls 4.8±0.01µs 4.8±0.01µs 0.00%
precise_decimal::add/0 9.0±0.01ns 9.0±0.01ns 0.00%
precise_decimal::add/rust-native 10.7±0.10ns 10.7±0.02ns 0.00%
precise_decimal::add/wasmi 420.4±2.89ns 422.7±2.08ns +0.55%
precise_decimal::add/wasmi-call-native 3.8±0.01µs 3.8±0.00µs 0.00%
precise_decimal::div/0 304.6±1.41ns 325.6±1.43ns +6.89%
precise_decimal::from_string/0 201.8±0.17ns 201.5±0.11ns -0.15%
precise_decimal::mul/0 332.8±0.81ns 353.5±0.33ns +6.22%
precise_decimal::mul/rust-native 289.4±1.89ns 286.1±0.92ns -1.14%
precise_decimal::mul/wasmi 48.2±0.24µs 48.2±0.14µs 0.00%
precise_decimal::mul/wasmi-call-native 4.3±0.00µs 4.2±0.01µs -2.33%
precise_decimal::pow/0 1751.5±6.31ns 1763.3±2.60ns +0.67%
precise_decimal::pow/rust-native 1360.2±0.56ns 1357.2±1.37ns -0.22%
precise_decimal::pow/wasmi 232.3±0.91µs 230.7±0.28µs -0.69%
precise_decimal::pow/wasmi-call-native 7.6±0.01µs 7.5±0.03µs -1.32%
precise_decimal::root/0 59.4±0.01µs 58.4±0.02µs -1.68%
precise_decimal::sub/0 9.1±0.05ns 9.1±0.02ns 0.00%
precise_decimal::to_string/0 695.6±0.30ns 693.2±0.55ns -0.35%
schema::validate_payload 380.5±0.80µs 381.8±0.28µs +0.34%
transaction::radiswap 5.0±0.05ms 4.9±0.03ms -2.00%
transaction::transfer 1791.1±4.44µs 1831.7±5.26µs +2.27%
transaction_validation::validate_manifest 43.0±0.03µs 43.0±0.04µs 0.00%
transaction_validation::verify_bls_2KB 1014.7±24.85µs 1082.5±20.69µs +6.68%
transaction_validation::verify_bls_32B 1000.8±6.41µs 1004.2±11.37µs +0.34%
transaction_validation::verify_ecdsa 74.6±0.06µs 74.6±0.05µs 0.00%
transaction_validation::verify_ed25519 47.7±0.05µs 42.6±0.12µs -10.69%

@alpeto9 alpeto9 requested a review from a team January 10, 2025 09:38
@dhedey dhedey merged commit c777b74 into develop Jan 13, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muzuke muzuke muzuke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alpeto9 @muzuke @dhedey @azizi-a