Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/support non fungibles in execution trace #2042

Merged
merged 5 commits into from
Jan 6, 2025
Merged

Feature/support non fungibles in execution trace #2042

merged 5 commits into from
Jan 6, 2025

Conversation

lrubasze
Copy link
Contributor

Summary

  • Add support for non-fungible resources in ExecutionTrace resource changes
  • Removed support for Recall operations in ExecutionTrace resource changes
    With recall it is not possible to determine the account the resources are recalled from, because recall operates with internal vault.

Testing

Relevant tests added

@lrubasze
Support TakeNonFungibles in vault ops
6a6ff5f
@lrubasze
Unsupport Recall from resource_changes in ExecutionTrace
63b6283 
With `recall` it is not possible to determine the account the
resources are recalled from, because recall operates with internal vault.
@lrubasze
Test execution tracing for non-fungible resources transfers
174b220
@lrubasze lrubasze force-pushed the feature/support_non_fungibles_in_execution_trace branch from c2b367a to 041d7ee Compare December 18, 2024 11:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Docker tags
docker.io/radixdlt/private-scrypto-builder:f9ac912f2b

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Benchmark for f9ac912

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.5±0.20ms 44.4±0.22ms -0.22%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.7±0.03ms 19.3±0.02ms -2.03%
costing::decode_encoded_i8_array_to_manifest_value 41.5±0.03ms 42.1±0.07ms +1.45%
costing::decode_encoded_tuple_array_to_manifest_raw_value 71.3±0.16ms 72.2±0.09ms +1.26%
costing::decode_encoded_tuple_array_to_manifest_value 99.2±0.20ms 98.6±0.19ms -0.60%
costing::decode_encoded_u8_array_to_manifest_raw_value 31.8±0.15µs 32.0±0.14µs +0.63%
costing::decode_encoded_u8_array_to_manifest_value 41.5±0.03ms 42.2±0.07ms +1.69%
costing::decode_rpd_to_manifest_raw_value 14.7±0.03µs 14.5±0.04µs -1.36%
costing::decode_rpd_to_manifest_value 10.9±0.03µs 10.8±0.02µs -0.92%
costing::deserialize_wasm 1221.0±7.91µs 1225.8±4.05µs +0.39%
costing::execute_transaction_creating_big_vec_substates 693.9±6.81ms 702.7±8.32ms +1.27%
costing::execute_transaction_reading_big_vec_substates 583.2±1.64ms 601.0±2.21ms +3.05%
costing::instantiate_flash_loan 1031.3±1246.38µs 875.1±219.66µs -15.15%
costing::instantiate_radiswap 989.7±945.55µs 900.5±442.98µs -9.01%
costing::scrypto_malloc 664.1±2.56ms 674.3±1.07ms +1.54%
costing::scrypto_sbor_decode 667.9±4.73ms 651.4±1.15ms -2.47%
costing::scrypto_sha256 588.4±1.29ms 575.5±0.69ms -2.19%
costing::spin_loop_v1 531.9±1.36ms 510.0±1.41ms -4.12%
costing::spin_loop_v2 618.6±2.22ms 599.2±0.29ms -3.14%
costing::validate_sbor_payload 29.1±0.05µs 29.9±0.06µs +2.75%
costing::validate_sbor_payload_bytes 245.7±0.63ns 251.7±1.53ns +2.44%
costing::validate_secp256k1 76.7±0.20µs 76.7±0.07µs 0.00%
costing::validate_wasm 33.5±0.04ms 33.4±0.04ms -0.30%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 322.0±1.29ns 317.3±1.26ns -1.46%
decimal::add/wasmi-call-native 2.9±0.00µs 3.0±0.00µs +3.45%
decimal::div/0 166.6±0.12ns 168.7±0.26ns +1.26%
decimal::from_string/0 156.9±0.08ns 166.1±0.12ns +5.86%
decimal::mul/0 128.1±0.19ns 129.3±0.08ns +0.94%
decimal::mul/rust-native 128.2±0.15ns 128.2±0.08ns 0.00%
decimal::mul/wasmi 22.2±0.07µs 18.8±0.05µs -15.32%
decimal::mul/wasmi-call-native 3.0±0.02µs 3.2±0.00µs +6.67%
decimal::pow/0 592.5±0.25ns 592.1±0.33ns -0.07%
decimal::pow/rust-native 591.6±0.33ns 591.7±0.55ns +0.02%
decimal::pow/wasmi 104.3±0.50µs 89.5±0.53µs -14.19%
decimal::pow/wasmi-call-native 5.1±0.01µs 4.9±0.00µs -3.92%
decimal::root/0 8.2±0.01µs 8.4±0.01µs +2.44%
decimal::sub/0 8.2±0.08ns 8.3±0.09ns +1.22%
decimal::to_string/0 443.9±0.79ns 447.9±0.75ns +0.90%
large_transaction_processing::prepare 2.6±0.00ms 2.5±0.00ms -3.85%
large_transaction_processing::prepare_and_decompile 6.2±0.02ms 6.3±0.02ms +1.61%
large_transaction_processing::prepare_and_decompile_and_recompile 26.2±1.87ms 31.8±0.29ms +21.37%
metadata_validation::validate_urls 4.8±0.02µs 4.7±0.01µs -2.08%
precise_decimal::add/0 8.7±0.06ns 8.7±0.05ns 0.00%
precise_decimal::add/rust-native 10.7±0.01ns 10.7±0.08ns 0.00%
precise_decimal::add/wasmi 419.7±4.70ns 415.4±1.16ns -1.02%
precise_decimal::add/wasmi-call-native 3.7±0.00µs 3.9±0.01µs +5.41%
precise_decimal::div/0 289.4±0.20ns 290.8±1.25ns +0.48%
precise_decimal::from_string/0 201.1±0.36ns 205.4±0.17ns +2.14%
precise_decimal::mul/0 332.7±0.36ns 328.7±0.47ns -1.20%
precise_decimal::mul/rust-native 284.8±0.48ns 287.4±0.54ns +0.91%
precise_decimal::mul/wasmi 48.7±0.29µs 47.5±0.22µs -2.46%
precise_decimal::mul/wasmi-call-native 4.2±0.00µs 4.2±0.01µs 0.00%
precise_decimal::pow/0 1717.8±1.37ns 1719.0±2.67ns +0.07%
precise_decimal::pow/rust-native 1358.4±1.50ns 1355.0±1.23ns -0.25%
precise_decimal::pow/wasmi 231.8±0.63µs 229.9±0.71µs -0.82%
precise_decimal::pow/wasmi-call-native 7.6±0.02µs 7.5±0.04µs -1.32%
precise_decimal::root/0 59.0±0.03µs 59.3±0.02µs +0.51%
precise_decimal::sub/0 8.8±0.02ns 8.9±0.09ns +1.14%
precise_decimal::to_string/0 697.6±0.33ns 697.7±0.82ns +0.01%
schema::validate_payload 384.3±0.68µs 382.9±0.48µs -0.36%
transaction::radiswap 5.0±0.02ms 4.9±0.02ms -2.00%
transaction::transfer 1819.5±10.61µs 1799.0±8.02µs -1.13%
transaction_validation::validate_manifest 43.2±0.04µs 43.2±0.19µs 0.00%
transaction_validation::verify_bls_2KB 1001.0±10.29µs 1004.7±15.38µs +0.37%
transaction_validation::verify_bls_32B 1063.3±16.74µs 1001.0±4.90µs -5.86%
transaction_validation::verify_ecdsa 74.8±0.17µs 74.7±0.05µs -0.13%
transaction_validation::verify_ed25519 42.2±0.06µs 45.9±0.05µs +8.77%

@lrubasze lrubasze force-pushed the feature/support_non_fungibles_in_execution_trace branch from 2a38ea3 to a4629ce Compare December 18, 2024 17:39
dhedey
dhedey approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@dhedey dhedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks :)

radix-engine/src/system/system_modules/execution_trace/module.rs Show resolved Hide resolved
@lrubasze lrubasze merged commit d6b146e into develop Jan 6, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhedey dhedey dhedey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrubasze @dhedey