Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugzilla#18710] Turn on warnPartialMatch* by default #165

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

[Bugzilla#18710] Turn on warnPartialMatch* by default #165

Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
c70cdeb
turn on warnPartialMatch* by default
MichaelChirico Apr 22, 2024
ea02dfd
cvp$just --> cvp$justification
MichaelChirico Apr 24, 2024
1afedf0
$coef --> $coefficients
MichaelChirico Apr 24, 2024
5a515cf
expr= --> exprs=
MichaelChirico Apr 24, 2024
cd9990b
edit in goldens
MichaelChirico Apr 24, 2024
ad2ed56
more found during compilation of datasets
MichaelChirico Apr 24, 2024
6835613
length= --> length.out=
MichaelChirico Apr 24, 2024
83ac892
partial matches in tests/arith-true.R
MichaelChirico Apr 24, 2024
e24848f
partial matches in tests/lm-tests.R
MichaelChirico Apr 24, 2024
f83604b
more partial match issues in tests/d-p-q-r-tests.R
MichaelChirico Apr 24, 2024
461c52e
even more in d-p-q-r-tests.R
MichaelChirico Apr 24, 2024
25eba0a
re-sync w goldens
MichaelChirico Apr 24, 2024
a2ea503
partial match issues in tests/complex.R
MichaelChirico Apr 24, 2024
cd59ae9
partial match issues in tests/lapack.R
MichaelChirico Apr 24, 2024
8018489
partial match issues in tests/print-tests.R
MichaelChirico Apr 24, 2024
ba464d9
partial match issues in tests/reg-tests-1{a,b}
MichaelChirico Apr 24, 2024
c90c571
partial matching in tests/reg-tests-1{c,d}.R
MichaelChirico Apr 24, 2024
2a87975
partial matching issues in tests/reg-tests-{1e,2}.R
MichaelChirico Apr 24, 2024
4b36f74
disable reg-tests for now given .Rout discrepancy
MichaelChirico Apr 24, 2024
e67cce8
view->viewports= in grid
MichaelChirico Apr 25, 2024
8494de5
full->fullNames= in tests
MichaelChirico Apr 25, 2024
24cd878
tol->tolerance= in stats tests
MichaelChirico Apr 25, 2024
aed64bd
fix issues in demo, intro, etc
MichaelChirico Apr 25, 2024
e36762c
another batch
MichaelChirico Apr 26, 2024
c8dc57d
update goldens, and one more issue
MichaelChirico Apr 26, 2024
59014e4
straggler
MichaelChirico Apr 26, 2024
c9cde3f
revert parts to be excluded from patch
MichaelChirico Apr 26, 2024
e1d6d3a
error: prcomp() has tol, not tolerance
MichaelChirico Apr 26, 2024
f1d5554
Rout.save exists here, inconsistently
MichaelChirico Apr 26, 2024
6fb6dcb
missed more partial matches in .R too
MichaelChirico Apr 26, 2024
6192ebf
another iteration of make check locally
MichaelChirico Apr 26, 2024
132bcc0
another error, and another intentional partial match
MichaelChirico Apr 26, 2024
3f7207f
another iteration
MichaelChirico Apr 26, 2024
b5bd327
another iteration
MichaelChirico Apr 26, 2024
7eb829c
sync again
MichaelChirico Apr 26, 2024
baead9c
one more
MichaelChirico Apr 26, 2024
c2e77cf
next iteration
MichaelChirico Apr 26, 2024
6018d46
next iteration
MichaelChirico Apr 26, 2024
945d089
next iteration
MichaelChirico Apr 26, 2024
39e2303
next iteration
MichaelChirico Apr 26, 2024
d502018
mistake: dpois() mysteriously has log=, not log.p=
MichaelChirico Apr 26, 2024
92ddef8
mistake: dt() mysteriously has log=, not log.p=
MichaelChirico Apr 26, 2024
f234e4e
next iteration
MichaelChirico Apr 26, 2024
2602432
mistake: i guess all d*() density functions use log=
MichaelChirico Apr 26, 2024
4a02077
next iteration
MichaelChirico Apr 26, 2024
10199db
next iteration
MichaelChirico Apr 26, 2024
11fbd0f
next iteration
MichaelChirico Apr 26, 2024
1e9445e
next iteration
MichaelChirico Apr 26, 2024
6c2119b
next iteration
MichaelChirico Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
next iteration
  • Loading branch information
@MichaelChirico
MichaelChirico committed Apr 26, 2024
commit 10199db1ccfb1ff9f2f80274f3f0443cc7bed2d7
2 changes: 1 addition & 1 deletion tests/d-p-q-r-tst-2.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ stopifnot(all.equal(qt(-1000, df = 4, log.p=TRUE),
-4.930611e108, tolerance = 1e-6))
qtp <- qt(-(20:850), df=1.2, log.p=TRUE, lower.tail=FALSE)
##almost: stopifnot(all(abs(5/6 - diff(log(qtp))) < 1e-11))
stopifnot(abs(5/6 - quantile(diff(log(qtp)), pr=c(0,0.995))) < 1e-11)
stopifnot(abs(5/6 - quantile(diff(log(qtp)), probs=c(0,0.995))) < 1e-11)

## close to df=1 (where Taylor steps are important!):
stopifnot(all.equal(-20, pt(qt(-20, df=1.02, log.p=TRUE),
Expand Down