test in firefox and chrome again

quickstrom · Aug 18, 2024 · 83a31e7 · 83a31e7
1 parent bada84a
commit 83a31e7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -23,6 +23,11 @@ jobs:
   integration-tests:
     needs: build
     runs-on: ubuntu-latest
+    strategy:      
+      matrix:      
+        browser:   
+          - chrome 
+          - firefox
     steps:
     - uses: actions/checkout@v2.3.1
     - uses: cachix/install-nix-action@v20
@@ -35,7 +40,7 @@ jobs:
         name: quickstrom
         signingKey: '${{ secrets.CACHIX_SIGNING_KEY }}'
     - run: nix show-config
-    - run: nix develop '.#integration-tests' --command integration-tests/run.py
+    - run: nix develop '.#integration-tests' --command integration-tests/run.py ${{matrix.browser}}
 
   lint-docs:
     runs-on: ubuntu-latest

diff --git a/integration-tests/run.py b/integration-tests/run.py
@@ -66,8 +66,11 @@ def run_tests(browser: str):
         run_test(browser, test)
 
 if __name__ == "__main__":
-    browser = "chrome"
+    browser = None
     if len(sys.argv) >= 2:
         browser = sys.argv[1]
+    else:
+        browser = "chrome"
+        print(f"No browser specified, defaulting to '{browser}'.")
 
     run_tests(browser)