Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky packet number skipping test #2786

Merged
merged 1 commit into from
Sep 17, 2020
Merged

fix flaky packet number skipping test #2786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix flaky packet number skipping test
  • Loading branch information
@marten-seemann
marten-seemann committed Sep 15, 2020
commit 5eaab7304363b6cce3947792f7fe50781b0c8082
3 changes: 2 additions & 1 deletion internal/ackhandler/sent_packet_handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,8 @@ var _ = Describe("SentPacketHandler", func() {
}))
Expect(handler.OnLossDetectionTimeout()).To(Succeed())
Expect(handler.SendMode()).To(Equal(SendPTOAppData))
Expect(handler.PopPacketNumber(protocol.Encryption1RTT)).To(Equal(pn + 2))
// The packet number generator might have introduced another skipped a packet number.
Expect(handler.PopPacketNumber(protocol.Encryption1RTT)).To(BeNumerically(">=", pn+2))
})

It("only counts ack-eliciting packets as probe packets", func() {
Expand Down