Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils(config/schema): updating schema for validation on /api/v1/superuser/config endpoint (PROJQUAY-4559) #3255

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

utils(config/schema): updating schema for validation on /api/v1/superuser/config endpoint (PROJQUAY-4559) #3255

wants to merge 6 commits into from

Conversation

michaelalang
Copy link
Contributor

With #3253 cleaning/syncing the schema of the attributes use/returned closes the loop on a verification process.
This helps identifying typos and obsolete configuration parameters.

This PR does not make sense without PR 3253.

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.48%. Comparing base (e9161cb) to head (1a856ae).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3255   +/-   ##
=======================================
  Coverage   70.48%   70.48%           
=======================================
  Files         442      442           
  Lines       41903    41903           
  Branches     5509     5509           
=======================================
  Hits        29535    29535           
- Misses      10629    10631    +2     
+ Partials     1739     1737    -2
Flag Coverage Δ
unit 70.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelalang
Copy link
Contributor Author

Unrelated Cypress tests failing ... again :D

 │ ✖  repository-autopruning.cy.ts             01:05       14       13        1        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  repository-delete.cy.ts                  00:04        1        1        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  repository-details.cy.ts                 02:34       37       36        -        1        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  repository-notifications.cy.ts           01:09       13       13        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✖  repository-permissions.cy.ts             00:49        6        5        1        -        - │

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelalang @app-sre-bot