Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: adding tag immutability to the api (PROJQUAY-7778) #3249

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

api: adding tag immutability to the api (PROJQUAY-7778) #3249

wants to merge 2 commits into from

Conversation

bcaton85
Copy link
Contributor

@bcaton85 bcaton85 commented Sep 19, 2024 •
edited
Loading

API changes required to support immutable tags. Includes the following features:

  • Modified API to support make a tag immutable
  • Preventing repositories from being set to mirror or proxy if they contain immutable tags
  • Preventing the deletion/retagging/editting labels/expiration of immutable tags
  • Setting tag immutability via manifest labels on push

This is the second commit of 4 from the original pull request: #1927. Previous commits:
[db: adding immutable column to tag table (PROJQUAY-7777)](#3195)

Co-Authored-By: dmesser dmesser@redhat.com

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 65.76271% with 101 lines in your changes missing coverage. Please review.

Project coverage is 70.39%. Comparing base (27d7c14) to head (cd5195c).

Files with missing lines Patch % Lines
endpoints/api/tag.py 50.00% 29 Missing and 16 partials ⚠️
data/model/oci/tag.py 81.81% 6 Missing and 6 partials ⚠️
data/registry_model/registry_oci_model.py 83.01% 3 Missing and 6 partials ⚠️
data/model/oci/label.py 52.94% 5 Missing and 3 partials ⚠️
endpoints/v2/manifest.py 0.00% 6 Missing ⚠️
endpoints/api/manifest.py 50.00% 5 Missing ⚠️
data/registry_model/label_handlers.py 60.00% 3 Missing and 1 partial ⚠️
endpoints/api/repository.py 20.00% 4 Missing ⚠️
data/model/proxy_cache.py 66.66% 1 Missing and 1 partial ⚠️
endpoints/api/organization.py 50.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3249      +/-   ##
==========================================
- Coverage   70.44%   70.39%   -0.05%     
==========================================
  Files         440      440              
  Lines       41684    41909     +225     
  Branches     5482     5548      +66     
==========================================
+ Hits        29365    29503     +138     
- Misses      10588    10647      +59     
- Partials     1731     1759      +28
Flag Coverage Δ
unit 70.39% <65.76%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bcaton85