Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics: report Quarkus platform as CUSTOM when it's not recognized #45501

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Analytics: report Quarkus platform as CUSTOM when it's not recognized #45501

merged 1 commit into from
Jan 10, 2025
+8 −2

Conversation

aloubyansky
Copy link
Member

Report Quarkus platform version as N/A when there are no platform BOMs detected and CUSTOM when platform BOMs are detected but the quarkus-bom is not among them

@aloubyansky
Report Quarkus platform version as N/A when there are no platform BOM…
b603789 
…s detected and CUSTOM when platform BOMs are detected but quarkus-bom is not among them
@aloubyansky aloubyansky requested a review from brunobat January 10, 2025 11:22
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jan 10, 2025
@aloubyansky aloubyansky mentioned this pull request Jan 10, 2025
Merged
brunobat
brunobat approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not back-port this.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 10, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b603789.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@aloubyansky aloubyansky merged commit f040b40 into quarkusio:main Jan 10, 2025
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobat brunobat brunobat approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
3.18 - main
Development

Successfully merging this pull request may close these issues.
2 participants
@aloubyansky @brunobat