Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use empty Set when no annotation present in injection point #45356

Merged
merged 1 commit into from
Jan 4, 2025
+4 −1
Merged

Use empty Set when no annotation present in injection point #45356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2386,7 +2386,6 @@ public static ResultHandle collectInjectionPointAnnotations(BeanDeployment beanD
if (injectionPoint.isSynthetic()) {
return bytecode.invokeStaticMethod(MethodDescriptors.COLLECTIONS_EMPTY_SET);
}
ResultHandle annotationsHandle = bytecode.newInstance(MethodDescriptor.ofConstructor(HashSet.class));
Collection<AnnotationInstance> annotations;
if (Kind.FIELD.equals(injectionPoint.getAnnotationTarget().kind())) {
FieldInfo field = injectionPoint.getAnnotationTarget().asField();
Expand All @@ -2396,6 +2395,10 @@ public static ResultHandle collectInjectionPointAnnotations(BeanDeployment beanD
annotations = Annotations.getParameterAnnotations(beanDeployment,
method, injectionPoint.getPosition());
}
if (annotations.isEmpty()) {
return bytecode.invokeStaticMethod(MethodDescriptors.COLLECTIONS_EMPTY_SET);
}
ResultHandle annotationsHandle = bytecode.newInstance(MethodDescriptor.ofConstructor(HashSet.class));
for (AnnotationInstance annotation : annotations) {
if (!injectionPointAnnotationsPredicate.test(annotation.name())) {
continue;
Expand Down
Loading