Avoid a warning for tests in interactive mode #37802
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CliHelpTest#testCommandHelp has become extremely flaky lately because for one run, a warning saying JBang is not installable is there and for the other it's not. This is problematic and I really don't see the value of adding a warning about JBang that is specifically only displayed for tests. Also fixed a bunch of typos and made the message more neutral (let's avoid using exclamation marks for messages and exceptions).
quarkus-bot
bot
added
area/cli
gsmet
commented
Dec 18, 2023
Comment on lines
-183
to
+182
| output.warn("JBang is not installable!"); | ||
| // this only happens for tests, do not output anything specific |
There was a problem hiding this comment.
This is where I remove the warning that is problematic for the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CliHelpTest#testCommandHelp has become extremely flaky lately because for one run, a warning saying JBang is not installable is there and for the other it's not. See https://ge.quarkus.io/s/gc7oirjtydrtg/tests/goal/io.quarkus:quarkus-cli:surefire:test@default-test/details/io.quarkus.cli.CliHelpTest/testCommandHelp?top-execution=1 for an example of the issue.
This is problematic and I really don't see the value of adding a warning about JBang that is specifically only displayed for tests.
Also fixed a bunch of typos and made the message more neutral (let's avoid using exclamation marks for messages and exceptions).