Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenshiftBaseXXXImage classes #37349

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Remove OpenshiftBaseXXXImage classes #37349

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bc5a93
refactor: remove OpenshiftBaseXXXImage classes
iocanel Nov 28, 2023
f6f8626
Fix OpenshiftWithS2iTest
gsmet Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix OpenshiftWithS2iTest 
JAVA_OPTS are not automatically added anymore.
But TBH, I wonder if it's the right move to not have these JAVA_OPTS as
we need to set the logger anyway.
  • Loading branch information
@gsmet
gsmet committed Dec 4, 2023
commit f6f8626f4d661cbcaab0d960c891e9a63f2e4187
5 changes: 0 additions & 5 deletions ...tes/quarkus-standard-way/src/test/java/io/quarkus/it/kubernetes/OpenshiftWithS2iTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,6 @@ public void assertGeneratedResources() throws IOException {
assertThat(envVar.getName()).isEqualTo("JAVA_APP_JAR");
//assertThat(envVar.getValue()).isEqualTo("/deployments/quarkus-run.jar"); // this is flaky
});
assertThat(envVars).anySatisfy(envVar -> {
assertThat(envVar.getName()).isEqualTo("JAVA_OPTIONS");
assertThat(envVar.getValue())
.contains("-Djava.util.logging.manager=org.jboss.logmanager.LogManager");
});
});
});

Expand Down
Loading