Maven CLI: better verbose + added debug for upgrade #36256
Conversation
quarkus-bot
bot
added
area/cli
gsmet
changed the title
| (v1, v2) -> { | ||
| throw new IllegalStateException(String.format("Recipe with the same path detected. Can not happen! (%s)", v1)); | ||
| }, |
There was a problem hiding this comment.
Should we merge them instead and ignore the dependency of the additional ones? Or we are sure this will never ever happen?
There was a problem hiding this comment.
@ia3andy WDYT? From my POV the file list is "created" during the browsing of the recipes from this jar. Key is the path (not only the file name) so there should be no duplicates.
There was a problem hiding this comment.
In fact there is no need to use a Map. Some kind of the List of the Pairs would be enough. I originally used List<Object[]>, but map looked better in my eyes. If needed I can refactor the code back to List of some Pair or Object[]....
There was a problem hiding this comment.
call the method getRecipesByName:)
There was a problem hiding this comment.
After consultation with @ia3andy, I changed the return type to the List<string[]>.
This comment has been minimized.
This comment has been minimized.
JiriOndrusek
force-pushed
the
maven-cli-debug
branch
2 times, most recently
from
620bbee to
34ddf52
Compare
|
There is probably missig some CI coverage, because the PR was green even without appropriate fix in the test. I added fix in the test code. (reflecting the change from Map to List) |
JiriOndrusek
force-pushed
the
maven-cli-debug
branch
from
34ddf52 to
baa26ce
Compare
| @@ -56,7 +56,7 @@ public static FetchResult fetchRecipes(MessageWriter log, MavenArtifactResolver | |||
| final Artifact artifact = artifactResolver.resolve(DependencyUtils.toArtifact(gav)).getArtifact(); | |||
| final ResourceLoader resourceLoader = ResourceLoaders.resolveFileResourceLoader( | |||
| artifact.getFile()); | |||
| final List<String> recipes = fetchRecipesAsList(resourceLoader, "quarkus-updates", recipeDirectoryNames); | |||
| final List<String[]> recipes = fetchRecipesAsList(resourceLoader, "quarkus-updates", recipeDirectoryNames); | |||
There was a problem hiding this comment.
I had another look at this and could we use a record instead of an obscure array? It's very cryptic and adding a record won't take much time.
|
@gsmet @JiriOndrusek What should we do about this one? |
|
Hi @cescoffier I totally forgot on this PR. |
JiriOndrusek
force-pushed
the
maven-cli-debug
branch
from
baa26ce to
a43a97c
Compare
JiriOndrusek
force-pushed
the
maven-cli-debug
branch
from
a43a97c to
e998f79
Compare
|
@gsmet I rebased the change to the current |
|
LGTM, but would rather wait for @gsmet |
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Quickstarts Compilation - JDK 17 | Compile Quickstarts |
Failures | Logs | Raw logs | 🚧 |
You can consult the Develocity build scans.
Failures
⚙️ Quickstarts Compilation - JDK 17 #
- Failing: security-webauthn-quickstart security-webauthn-reactive-quickstart
📦 security-webauthn-quickstart
✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project security-webauthn-quickstart: Compilation failure
📦 security-webauthn-reactive-quickstart
✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project security-webauthn-reactive-quickstart: Compilation failure
Flaky tests - Develocity
⚙️ JVM Tests - JDK 21
📦 extensions/smallrye-reactive-messaging/deployment
✖ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History
Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"]-java.lang.AssertionError
java.lang.AssertionError:
Expecting actual:
["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
["-3", "-4", "-5", "-6"]
at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)
fixes #36255