Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws lambda codestart #34129

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aloubyansky
Copy link
Member

@patriot1burke WDYT about extracting the manage.sh and other resources from the extension to the the AWS Lambda codestart?
It would be generated in the project's resources directory and copied to target/aws directory with filtering enabled during the build. It would allow

  • adjusting the script using properties set in the POM, such maven.compiler.release that would set the runtimeXX for the function;
  • adjust and commit the script to git.

@quarkus-bot quarkus-bot bot added area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 19, 2023
@maxandersen
Copy link
Member

another (future?) option would be to make that script a plugin that the extension could register and then it would be workable on windows too.

@aloubyansky
Copy link
Member Author

Would it allow customizing the script though by the user?
An equivalent script for Windows could be added too, we should agree on the approach we want to take here.

@patriot1burke
Copy link
Contributor

You like the idea of depending on a codestart for basic functions to work? i.e. deploy, run, invoke, delete/undeploy?

@patriot1burke
Copy link
Contributor

I also don't like the idea of adding more to the pom. Extensions should be doing this automatically with config overrides being available. Can we have maven/gradle publish java compile version as an atttribute that extensions could find?

@patriot1burke
Copy link
Contributor

FYI: Azure Functions is in a good place. Going to be working on Lambda next to add quarkus:run, quarkus:deploy, and @QuarkusIntegrationTest features like I have for Azure Functions. Thinking of adding a quarkus:undeploy generic action too. The only thing missing really is quarkus:invoke, but only Lambda seems to have that action.

@aloubyansky
Copy link
Member Author

I haven't really put a lot of thought into this. Not sure what you have in mind as a roadmap. I just noticed most of the content is hardcoded and would be good if a user could adjust it w/o a rebuild re-generating it all. So just based on that I'd put it under resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants