Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use graal-sdk instead of svm #246

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Use graal-sdk instead of svm #246

merged 1 commit into from
Jul 14, 2023

Conversation

gastaldi
Copy link
Member

@github-actions
Copy link

github-actions bot commented Jul 14, 2023

🚦Reports for run #592🚦

Reports will be posted here as they get available.

🥳 JUnit Native Test passed

Passed Failed Skipped
✅ 76 ❌ 0 ⚠️ 0

You can see the report here.

🥳 JUnit JVM Test passed

Passed Failed Skipped
✅ 118 ❌ 0 ⚠️ 0

You can see the report here.

@turing85
Copy link
Contributor

turing85 commented Jul 14, 2023

@gastaldi As far as I can see, this change should not be downstreamed to the 2.x versions, right? Also: for what version(s) (exactly) will those changes take effect? This looks like a breaking change. Do we need a separate 3.0.x branch to support older versions?

@gastaldi
Copy link
Member Author

gastaldi commented Jul 14, 2023

Because org.graalvm.sdk:graal-sdk is already in (always has been) in the Quarkus application's BOM, I don't believe there is a need to have a separate branch.

It is a breaking change in the sense that the dependency is no longer available in the BOM, but it doesn't require changing any sources.

@gastaldi As far as I can see, this change should not be downstreamed to the 2.x versions, right?

No, there are no plans to release another 2.x version

@turing85
Copy link
Contributor

@gastaldi thanks for the clarification 🙂

@turing85
Copy link
Contributor

Final question: (when) will svm be removed? I.e. when do we need to release a new version?

@maxandersen
Copy link
Member

Do we need a separate 3.0.x branch to support older versions?

you most likely will unless you don't use any jakarta/javax dependencies ?

@maxandersen
Copy link
Member

@turing85 in 3.2.1 is the plan. next week :/

@turing85
Copy link
Contributor

Do we need a separate 3.0.x branch to support older versions?

you most likely will unless you don't use any jakarta/javax dependencies ?

What does jakarta have to do with the svm dependency?
If you mean the switch from JavaEE to JakartaEE: we already migrated; that's what the 2.x branch is for.

@maxandersen
Copy link
Member

@turing85

What does jakarta have to do with the svm dependency?
If you mean the switch from JavaEE to JakartaEE: we already migrated; that's what the 2.x branch is for.

sorry - I thought you mean Quarkus 2.0 vs 3.0 - if already branched you should be fine.

@gemmellr
Copy link
Contributor

gemmellr commented Jul 14, 2023

I think the question was misunderstood. The graal-sdk dep has been in the bom for ages (e.g 3.0.0) so as George said, it doesnt seem like you should need a branch for older 3.x versions.

I've made the switch and released quarkus-qpid-jms against Quarkus 3.2 again without issue.

@gemmellr
Copy link
Contributor

@turing85 in 3.2.1 is the plan. next week :/

Is it? The PR isnt marked for backport and prior discussion suggested it would wait for 3.3

@turing85
Copy link
Contributor

Should we move the discussion to the mailing list? I imagine there are other quarkiverse extensions that are affected as well.

@gastaldi
Copy link
Member Author

Yeah, I should have done that before opening the PRs, sorry. I'll start a thread in the quarkus-dev list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants