deleting the default stack should error

[buildpacks#37]
quantumsheep · Oct 4, 2018 · f44f008 · f44f008
1 parent 1da8be1
commit f44f008
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/config/config.go b/config/config.go
@@ -99,6 +99,9 @@ func (c *Config) Add(stack Stack) error {
 }
 
 func (c *Config) Delete(stackName string) error {
+	if c.DefaultStackID == stackName {
+		return fmt.Errorf(`%s cannot be deleted when it is the default stack. You can change your default stack by running "pack set-default-stack".`, stackName)
+	}
 	for i, s := range c.Stacks {
 		if s.ID == stackName {
 			c.Stacks = append(c.Stacks[:i], c.Stacks[i+1:]...)

diff --git a/config/config_test.go b/config/config_test.go
@@ -270,6 +270,7 @@ default-stack-id = "my.stack"
 		var subject *config.Config
 		it.Before(func() {
 			assertNil(t, ioutil.WriteFile(filepath.Join(tmpDir, "config.toml"), []byte(`
+default-stack-id = "stack-1"
 [[stacks]]
   id = "stack-1"
 [[stacks]]
@@ -308,6 +309,14 @@ default-stack-id = "my.stack"
 				assertEq(t, err.Error(), `stack "other.stack" does not exist`)
 			})
 		})
+
+		when("stack to be deleted is the default-stack-id", func() {
+			it("errors and leaves file unchanged", func() {
+				err := subject.Delete("stack-1")
+				assertNotNil(t, err)
+				assertEq(t, err.Error(), `stack-1 cannot be deleted when it is the default stack. You can change your default stack by running "pack set-default-stack".`)
+			})
+		})
 	})
 
 	when("ImageByRegistry", func() {