Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement _value_equality_approximate_values_ for PhasedISwapPowGate. #6959

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codrut3
Copy link
Contributor

@codrut3 codrut3 commented Jan 18, 2025

This fixes the problem that phase_exponent is not taken into account for approx_eq.

Fixes: #6529

This fixes the problem that phase_exponent is not taken into account
for approx_eq.
@codrut3 codrut3 requested review from vtomole and a team as code owners January 18, 2025 17:28
@codrut3 codrut3 requested a review from mhucka January 18, 2025 17:28
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jan 18, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (05bb69a) to head (85da4ba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6959   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files        1084     1084           
  Lines       94766    94783   +17     
=======================================
+ Hits        92755    92772   +17     
  Misses       2011     2011           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phase exponent ignored in approximate comparisons of cirq.PhasedISwapPowGate
3 participants