Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a default fallback for the equal_up_to_global_phase protocol #6950

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a default fallback for the equal_up_to_global_phase protocol #6950

wants to merge 2 commits into from

Conversation

dstrain115
Copy link
Collaborator

  • This will add a default fallback for cirq.Gate instances to use their unitary decomposition for the equal_up_to_global_phase protocol.

Fixes: #6574

@dstrain115
Add a default fallback for the equal_up_to_global_phase protocol
1c1d835 
- This will add a default fallback for cirq.Gate instances to use
their unitary decomposition for the equal_up_to_global_phase protocol.

Fixes: quantumlib#6574
@dstrain115 dstrain115 requested review from vtomole and a team as code owners January 14, 2025 14:40
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@5ffb3ad). Learn more about missing BASE report.
Report is 47 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6950   +/-   ##
=======================================
  Coverage        ?   97.86%           
=======================================
  Files           ?     1084           
  Lines           ?    94413           
  Branches        ?        0           
=======================================
  Hits            ?    92401           
  Misses          ?     2012           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CirqBot CirqBot added the size: S 10< lines changed <50 label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@95-martin-orion 95-martin-orion Awaiting requested review from 95-martin-orion 95-martin-orion is a code owner automatically assigned from quantumlib/cirq-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

equal_up_to_global_phase on gates doesn't work as expected
2 participants
@dstrain115 @CirqBot