Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize processor sampler with the default device config key #6521

Merged
merged 18 commits into from
Mar 27, 2024
Merged

Initialize processor sampler with the default device config key #6521

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
bcd3533
add default device config key to grid device metadata
senecameeks Mar 22, 2024
69ed553
Revert "add default device config key to grid device metadata"
senecameeks Mar 22, 2024
bc55c9d
initialize sampler with default device config key and add tests
senecameeks Mar 23, 2024
9b1309b
add properties to sampler
senecameeks Mar 25, 2024
7845b3c
dedupe DeviceConfigK, onewas renamed to DeviceConfigSelector
senecameeks Mar 25, 2024
73a493d
spelling
senecameeks Mar 25, 2024
e2cf369
coverage
senecameeks Mar 25, 2024
92637bf
Merge branch 'main' into u/smeeks/add_default_device_config_key_to_me…
senecameeks Mar 25, 2024
42c4939
address comments
senecameeks Mar 25, 2024
47a7e3f
add fake engine context and client for testing
senecameeks Mar 25, 2024
02e54c7
lint
senecameeks Mar 25, 2024
eaf153c
use new FakeEngineContext
senecameeks Mar 25, 2024
0e1726e
typecheck
senecameeks Mar 25, 2024
53a66a5
lint , local env not catching CI errors
senecameeks Mar 25, 2024
10d42bb
signature of fakes match real impls
senecameeks Mar 26, 2024
85c28c4
add logic to initialize default values instead of throwing value error
senecameeks Mar 26, 2024
4848cb0
lint
senecameeks Mar 26, 2024
a70f2ff
rm logging and prefer to throw value error
senecameeks Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use new FakeEngineContext
  • Loading branch information
@senecameeks
senecameeks committed Mar 25, 2024
commit eaf153c8bf2a7b5e694b66449d7679af9509b7fb
7 changes: 3 additions & 4 deletions cirq-google/cirq_google/engine/engine_processor_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,8 @@ def __init__(self):
super().__init__()
self._processor = quantum.QuantumProcessor()

@duet.sync
async def get_processor_async(
self, project_id: str = "", processor_id: str = ""
def get_processor(
self, unused_project_id: str = "", unused_processor_id: str = ""
) -> quantum.QuantumProcessor:
return self._processor

Expand Down Expand Up @@ -352,7 +351,7 @@ def test_get_sampler_loads_processor_with_default_device_configuration() -> None
)
)
)
processor = cg.EngineProcessor('a', 'p', EngineContext(client=client))
processor = cg.EngineProcessor('a', 'p', FakeEngineContext(client=client))
sampler = processor.get_sampler()

assert sampler.run_name == "run"
Expand Down
Loading